* [2.6 patch] remove drivers/char/h8.{c,h}
@ 2004-07-02 22:41 Adrian Bunk
2004-07-02 23:56 ` Richard Henderson
0 siblings, 1 reply; 2+ messages in thread
From: Adrian Bunk @ 2004-07-02 22:41 UTC (permalink / raw)
To: rth; +Cc: linux-kernel
Hi Richard,
I didn't get an answer regarding the following mail sent one year ago:
----- Forwarded message from Adrian Bunk <bunk@fs.tum.de> -----
Date: Mon, 14 Jul 2003 00:43:30 +0200
From: Adrian Bunk <bunk@fs.tum.de>
To: rth@twiddle.net
Cc: linux-kernel@vger.kernel.org
Subject: Remove CONFIG_H8 in 2.5?
CONFIG_H8 in drivers/char/ depend in both 2.4 and 2.5 on
CONFIG_OBSOLETE.
Since CONFIG_OBSOLETE is never set it is not selectable.
Is there any reason why this driver should stay in the kernel or would
you accept a patch that removes this driver?
cu
Adrian
----- End forwarded message -----
Since this issue is still present in current 2.6 kernels, I'd suggest
the following:
rm drivers/char/h8.c
rm drivers/char/h8.h
Signed-off-by: Adrian Bunk <bunk@fs.tum.de>
--- linux-2.6.7-mm5-full/drivers/char/Kconfig.old 2004-07-03 00:36:17.000000000 +0200
+++ linux-2.6.7-mm5-full/drivers/char/Kconfig 2004-07-03 00:36:39.000000000 +0200
@@ -795,16 +795,6 @@
This option enables support for the LCD display and buttons found
on Cobalt systems through a misc device.
-config H8
- bool "Tadpole ANA H8 Support (OBSOLETE)"
- depends on OBSOLETE && ALPHA_BOOK1
- help
- The Hitachi H8/337 is a microcontroller used to deal with the power
- and thermal environment. If you say Y here, you will be able to
- communicate with it via a character special device.
-
- If unsure, say N.
-
config DTLK
tristate "Double Talk PC internal speech card support"
help
--- linux-2.6.7-mm5-full/drivers/char/Makefile.old 2004-07-03 00:37:03.000000000 +0200
+++ linux-2.6.7-mm5-full/drivers/char/Makefile 2004-07-03 00:37:14.000000000 +0200
@@ -69,7 +69,6 @@
obj-$(CONFIG_QIC02_TAPE) += tpqic02.o
obj-$(CONFIG_FTAPE) += ftape/
obj-$(CONFIG_COBALT_LCD) += lcd.o
-obj-$(CONFIG_H8) += h8.o
obj-$(CONFIG_PPDEV) += ppdev.o
obj-$(CONFIG_NWBUTTON) += nwbutton.o
obj-$(CONFIG_NWFLASH) += nwflash.o
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [2.6 patch] remove drivers/char/h8.{c,h}
2004-07-02 22:41 [2.6 patch] remove drivers/char/h8.{c,h} Adrian Bunk
@ 2004-07-02 23:56 ` Richard Henderson
0 siblings, 0 replies; 2+ messages in thread
From: Richard Henderson @ 2004-07-02 23:56 UTC (permalink / raw)
To: Adrian Bunk; +Cc: linux-kernel
On Sat, Jul 03, 2004 at 12:41:01AM +0200, Adrian Bunk wrote:
> Since CONFIG_OBSOLETE is never set it is not selectable.
> Is there any reason why this driver should stay in the kernel or would
> you accept a patch that removes this driver?
Kill it.
r~
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2004-07-02 23:57 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2004-07-02 22:41 [2.6 patch] remove drivers/char/h8.{c,h} Adrian Bunk
2004-07-02 23:56 ` Richard Henderson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox