public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Pavel Machek <pavel@ucw.cz>
To: Christoph Hellwig <hch@ucw.cz>,
	torvalds@osdl.org, linux-kernel@vger.kernel.org
Subject: Re: current BK compilation failure on ppc32
Date: Sat, 3 Jul 2004 22:50:23 +0200	[thread overview]
Message-ID: <20040703205023.GF31892@elf.ucw.cz> (raw)
In-Reply-To: <20040703185606.GA4718@lst.de>

Hi!

> kernel/power/smp.c: In function `smp_pause':
> kernel/power/smp.c:24: error: storage size of `ctxt' isn't known
> kernel/power/smp.c:24: warning: unused variable `ctxt'
> 
> kernel/power/smp.c seems to be inherently swsusp-specific but is
> compiled for CONFIG_PM. (Same seems to be true for amny other files
> in kernel/power/, but as they compile it only causes bloat..)

Patch is good, thanks and sorry for breakage.
								Pavel

> --- 1.10/kernel/power/Makefile	2004-07-02 07:23:47 +02:00
> +++ edited/kernel/power/Makefile	2004-07-03 22:07:29 +02:00
> @@ -1,5 +1,7 @@
>  obj-y				:= main.o process.o console.o pm.o
> +ifeq ($(CONFIG_SOFTWARE_SUSPEND), y)
>  obj-$(CONFIG_SMP)		+= smp.o
> +endif
>  obj-$(CONFIG_SOFTWARE_SUSPEND)	+= swsusp.o
>  obj-$(CONFIG_PM_DISK)		+= disk.o pmdisk.o
>  

-- 
People were complaining that M$ turns users into beta-testers...
...jr ghea gurz vagb qrirybcref, naq gurl frrz gb yvxr vg gung jnl!

  reply	other threads:[~2004-07-03 20:50 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-07-03 18:56 current BK compilation failure on ppc32 Christoph Hellwig
2004-07-03 20:50 ` Pavel Machek [this message]
2004-07-03 21:45 ` Linus Torvalds
2004-07-04  8:29   ` Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20040703205023.GF31892@elf.ucw.cz \
    --to=pavel@ucw.cz \
    --cc=hch@ucw.cz \
    --cc=linux-kernel@vger.kernel.org \
    --cc=torvalds@osdl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox