From: Christoph Hellwig <hch@lst.de>
To: Linus Torvalds <torvalds@osdl.org>
Cc: Christoph Hellwig <hch@lst.de>,
pavel@ucw.cz, linux-kernel@vger.kernel.org
Subject: Re: current BK compilation failure on ppc32
Date: Sun, 4 Jul 2004 10:29:38 +0200 [thread overview]
Message-ID: <20040704082938.GA14313@lst.de> (raw)
In-Reply-To: <Pine.LNX.4.58.0407031439240.15998@ppc970.osdl.org>
> Don't do it like that.
>
> Instead, do something like
>
> smp-power-$(CONFIG_SMP) += smp.o
> obj-$(CONFIG_SOFTWARE_SUSPEND) += $(smp-power-y)
>
> which not only is shorter, but gets a _lot_ more readable after a while.
New patch below:
--- 1.10/kernel/power/Makefile 2004-07-02 07:23:47 +02:00
+++ edited/kernel/power/Makefile 2004-07-04 12:21:57 +02:00
@@ -1,6 +1,8 @@
+
+swsusp-smp-$(CONFIG_SMP) += smp.o
+
obj-y := main.o process.o console.o pm.o
-obj-$(CONFIG_SMP) += smp.o
-obj-$(CONFIG_SOFTWARE_SUSPEND) += swsusp.o
+obj-$(CONFIG_SOFTWARE_SUSPEND) += swsusp.o $(swsusp-smp-y)
obj-$(CONFIG_PM_DISK) += disk.o pmdisk.o
obj-$(CONFIG_MAGIC_SYSRQ) += poweroff.o
prev parent reply other threads:[~2004-07-04 8:29 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-07-03 18:56 current BK compilation failure on ppc32 Christoph Hellwig
2004-07-03 20:50 ` Pavel Machek
2004-07-03 21:45 ` Linus Torvalds
2004-07-04 8:29 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040704082938.GA14313@lst.de \
--to=hch@lst.de \
--cc=linux-kernel@vger.kernel.org \
--cc=pavel@ucw.cz \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox