public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Pavel Machek <pavel@ucw.cz>
To: Erik Rigtorp <erik@rigtorp.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] kernel/power/swsusp.c
Date: Sun, 4 Jul 2004 17:18:49 +0200	[thread overview]
Message-ID: <20040704151848.GC8488@elf.ucw.cz> (raw)
In-Reply-To: <20040704133715.GA4717@linux.nu>

Hi!

> > You are moving it inside function that should have no business doing
> > this... Would something like this work better? [hand-edited, apply by
> > hand; untested].
> 
> Your patch works fine but now the swsusp resume messages appears on the
> normal console instead. The swsusp console should be allocated earlier as my
> patch did.

Actually, this has several advantages -- you can actually see the
messages of the kernel during resume. And reading does logically
belong to the kernel doing boot, so it belongs on its screen, too...

								Pavel
-- 
People were complaining that M$ turns users into beta-testers...
...jr ghea gurz vagb qrirybcref, naq gurl frrz gb yvxr vg gung jnl!

  reply	other threads:[~2004-07-04 15:19 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-07-03 17:28 [PATCH] kernel/power/swsusp.c Erik Rigtorp
2004-07-03 20:46 ` Pavel Machek
2004-07-04 11:49   ` Erik Rigtorp
2004-07-04 22:50     ` Nigel Cunningham
2004-07-04 13:37   ` Erik Rigtorp
2004-07-04 15:18     ` Pavel Machek [this message]
2004-07-05 10:54       ` Erik Rigtorp
2004-07-05 15:13         ` Pavel Machek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20040704151848.GC8488@elf.ucw.cz \
    --to=pavel@ucw.cz \
    --cc=erik@rigtorp.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox