public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Alan Cox <alan@redhat.com>
To: Tigran Aivazian <tigran@aivazian.fsnet.co.uk>
Cc: Marcelo Tosatti <marcelo.tosatti@cyclades.com>,
	linux-kernel@vger.kernel.org, Alan Cox <alan@redhat.com>
Subject: Re: question about /proc/<PID>/mem in 2.4
Date: Tue, 6 Jul 2004 12:31:41 -0400	[thread overview]
Message-ID: <20040706163141.GI11736@devserv.devel.redhat.com> (raw)
In-Reply-To: <Pine.LNX.4.44.0407061406200.20027-100000@localhost.localdomain>

On Tue, Jul 06, 2004 at 02:08:04PM +0100, Tigran Aivazian wrote:
> > This code was added to stop the ptrace/kmod vulnerabilities. I do not 
> > fully understand the issues around tsk->is_dumpable and the fix itself,
> > but I agree on that the checks here could be relaxed for the super user.

is_dumpable tells you various things in 2.4, including whether the
curent memory image is valid, and as a race preventor for ptrace during
exec of setuid apps. You should probably talk to Solar Designer about
the whole design of the dump/suid race fixing work rather than me.

We also had to deal with another nasty case which could be fixed by grabbing
the mm at open time (which then opens a resource attack bug).

Consider what happens if your setuid app reads stdin

	setuidapp < /proc/self/mem

(No idea how 2.6 deals with these but if its got better backportable ways
 that *actually work* it might make sense).



  reply	other threads:[~2004-07-06 16:32 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-07-05 13:27 question about /proc/<PID>/mem in 2.4 Tigran Aivazian
2004-07-05 13:37 ` FabF
2004-07-05 14:22   ` Tigran Aivazian
2004-07-05 14:25     ` FabF
2004-07-06 11:14       ` Tigran Aivazian
2004-07-06 10:49         ` Arjan van de Ven
2004-07-06 11:35           ` Tigran Aivazian
2004-07-06 11:04         ` Marcelo Tosatti
2004-07-06 13:08           ` Tigran Aivazian
2004-07-06 16:31             ` Alan Cox [this message]
2004-07-07 13:53               ` Tigran Aivazian
2004-07-07 13:26                 ` Tigran Aivazian
2004-07-07 16:21                   ` Daniel Jacobowitz
2004-07-07 16:13                 ` Alan Cox

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20040706163141.GI11736@devserv.devel.redhat.com \
    --to=alan@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=marcelo.tosatti@cyclades.com \
    --cc=tigran@aivazian.fsnet.co.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox