Re: 2.6.7-mm6 - ppc32 inconsistent kallsyms data

[jhf@rivenstone.net (Joseph Fannin)]

[-- Attachment #1: Type: text/plain, Size: 982 bytes --]

On Tue, Jul 06, 2004 at 05:43:01PM +1000, Keith Owens wrote:
> I hate it when I spot a typo after pressing enter ...
> 
> 
> PPC small data area base symbols shift between kallsyms phases 1 and 2,
> which makes the kallsyms data unstable.  Exclude them from the kallsyms
> list.

   Yes, this builds okay with KALLSYMS_EXTRA_PASS off.

 
> Signed-off-by: Keith Owens <kaos@sgi.com>
> 
> Index: 2.6.7-mm6/scripts/kallsyms.c
> ===================================================================
> +++ 2.6.7-mm6/scripts/kallsyms.c	2004-07-06 17:41:29.000000000 +1000
> @@ -83,6 +83,11 @@ symbol_valid(struct sym_entry *s)
>  	    strcmp(s->sym, "kallsyms_names") == 0)
>  		return 0;
>  
> +	/* Exclude linker generated symbols which vary between passes */
> +	if (strcmp(s->sym, "_SDA_BASE_") == 0 ||	/* ppc */
> +	    strcmp(s->sym, "_SDA2_BASE_") == 0)		/* ppc */
> +		return 0;
> +
>  	return 1;
>  }
>  
> 

-- 
Joseph Fannin
jhf@rivenstone.net


[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 189 bytes --]