Re: 2.6.7-mm6

Ingo Molnar
2004-07-09T06:28:26Z

* Nick Piggin <nickpiggin@yahoo.com.au> wrote:

> >Please present a self-contained fixed-up init_idle() cleanup for me to
> >testboot. Even the one in -mm is not so, as it depends on later patches
> >to even compile.
>
> The patch I just sent (which is on top of -mm6) should hopefully
> work... if you feel like testing a solution that may still get
> vetoed by Ingo.

looks fine to me. It somewhat reduces the utility of copy_process()
[which we primarily introduced to enable wakeup-less SMP bootstrapping],
but i cannot see any good solution besides moving copy_thread() out of
copy_process(), which is unsafe. (ptrace could potentially access the
new task before copy_thread() is done, etc.) So i'd go for the simple
solution of CLONE_IDLETASK not doing a wakeup.

Ingo