[PATCH] modular swim3

[PATCH] modular swim3

[Christoph Hellwig]

Needs one magic mediabay symbol exported.  I've also moved the Kconfig
entry to where it belongs.


--- 1.24/drivers/block/Kconfig	2004-06-21 20:52:50 +02:00
+++ edited/drivers/block/Kconfig	2004-07-07 23:30:10 +02:00
@@ -33,6 +33,13 @@
 	  Say Y here to support the SWIM (Super Woz Integrated Machine) IOP
 	  floppy controller on the Macintosh IIfx and Quadra 900/950.
 
+config MAC_FLOPPY
+	tristate "Support for PowerMac floppy"
+	depends on PPC_PMAC && !PPC_PMAC64
+	help
+	  If you have a SWIM-3 (Super Woz Integrated Machine 3; from Apple)
+	  floppy controller, say Y here. Most commonly found in PowerMacs.
+
 config BLK_DEV_PS2
 	tristate "PS/2 ESDI hard disk support"
 	depends on MCA && MCA_LEGACY
--- 1.7/drivers/macintosh/Kconfig	2004-05-19 18:02:46 +02:00
+++ edited/drivers/macintosh/Kconfig	2004-07-07 23:49:37 +02:00
@@ -118,13 +118,6 @@
 	  events; also, the PowerBook button device will be enabled so you can
 	  change the screen brightness.
 
-config MAC_FLOPPY
-	bool "Support for PowerMac floppy"
-	depends on PPC_PMAC && !PPC_PMAC64
-	help
-	  If you have a SWIM-3 (Super Woz Integrated Machine 3; from Apple)
-	  floppy controller, say Y here. Most commonly found in PowerMacs.
-
 config MAC_SERIAL
 	tristate "Support for PowerMac serial ports (OBSOLETE DRIVER)"
 	depends on PPC_PMAC && BROKEN
--- 1.12/drivers/macintosh/mediabay.c	2004-03-14 02:57:41 +01:00
+++ edited/drivers/macintosh/mediabay.c	2004-07-08 00:06:35 +02:00
@@ -435,6 +435,7 @@
 #endif /* CONFIG_BLK_DEV_IDE */
 	return -ENODEV;
 }
+EXPORT_SYMBOL(check_media_bay);
 
 int __pmac check_media_bay_by_base(unsigned long base, int what)
 {

Re: [PATCH] modular swim3

[Benjamin Herrenschmidt]

On Wed, 2004-07-07 at 15:39, Christoph Hellwig wrote:
> Needs one magic mediabay symbol exported.  I've also moved the Kconfig
> entry to where it belongs.

Hrm... I wouldn't recommend anybody to try to rmmod it though ...

Ben.

Re: [PATCH] modular swim3

[Christoph Hellwig]

On Wed, Jul 07, 2004 at 03:48:38PM -0500, Benjamin Herrenschmidt wrote:
> On Wed, 2004-07-07 at 15:39, Christoph Hellwig wrote:
> > Needs one magic mediabay symbol exported.  I've also moved the Kconfig
> > entry to where it belongs.
> 
> Hrm... I wouldn't recommend anybody to try to rmmod it though ...

it's doesn't have a module_exit() entry point, so it's unloadable anyway

Re: [PATCH] modular swim3

[Paul Wagland]

[-- Attachment #1: Type: text/plain, Size: 621 bytes --]


On Jul 7, 2004, at 22:48, Benjamin Herrenschmidt wrote:

> On Wed, 2004-07-07 at 15:39, Christoph Hellwig wrote:
>> Needs one magic mediabay symbol exported.  I've also moved the Kconfig
>> entry to where it belongs.
>
> Hrm... I wouldn't recommend anybody to try to rmmod it though ...

This is an interesting concept, is it possible to mark a module such 
that it should not be removed. There have been many instances on the 
list where it has been said that rmmod is the enemy of stability, and 
so long as only modules that you need are loaded then there should not 
be much pressure to unload them...

Cheers,
Paul

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 186 bytes --]