From: Greg KH <greg@kroah.com>
To: Alan Stern <stern@rowland.harvard.edu>
Cc: Jesse Stockall <stockall@magma.ca>,
USB development list <linux-usb-devel@lists.sourceforge.net>,
Kernel development list <linux-kernel@vger.kernel.org>
Subject: Re: PATCH: (as339) Interpret down_trylock() result code correctly in usb.c
Date: Wed, 7 Jul 2004 14:54:16 -0700 [thread overview]
Message-ID: <20040707215416.GC4514@kroah.com> (raw)
In-Reply-To: <Pine.LNX.4.44L0.0407061202340.5551-100000@ida.rowland.org>
On Tue, Jul 06, 2004 at 12:11:19PM -0400, Alan Stern wrote:
> Greg:
>
> As Andrew Morton has already spotted, I messed up the interpretation of
> the result codes from various _trylock() routines. I didn't notice that
> down_trylock() and down_read_trylock() use opposite conventions for
> indicating success! This patch fixes the incorrect interpretation of
> down_trylock(). That error may well be responsible for some of the
> problems cropping up recently with OHCI controllers. Please apply.
Applied.
But even with this patch, and Andrew's, I have a hang at boot with my
USB mouse plugged in (uhci system).
thanks,
greg k-h
next prev parent reply other threads:[~2004-07-07 21:56 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-07-06 16:11 PATCH: (as339) Interpret down_trylock() result code correctly in usb.c Alan Stern
2004-07-07 21:54 ` Greg KH [this message]
2004-07-07 22:08 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040707215416.GC4514@kroah.com \
--to=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb-devel@lists.sourceforge.net \
--cc=stern@rowland.harvard.edu \
--cc=stockall@magma.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox