From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S265541AbUGGWLM (ORCPT ); Wed, 7 Jul 2004 18:11:12 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S265540AbUGGWLL (ORCPT ); Wed, 7 Jul 2004 18:11:11 -0400 Received: from mail.kroah.org ([69.55.234.183]:10404 "EHLO perch.kroah.org") by vger.kernel.org with ESMTP id S265545AbUGGWKB (ORCPT ); Wed, 7 Jul 2004 18:10:01 -0400 Date: Wed, 7 Jul 2004 15:08:25 -0700 From: Greg KH To: Alan Stern Cc: Jesse Stockall , USB development list , Kernel development list Subject: Re: PATCH: (as339) Interpret down_trylock() result code correctly in usb.c Message-ID: <20040707220825.GD4990@kroah.com> References: <20040707215416.GC4514@kroah.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20040707215416.GC4514@kroah.com> User-Agent: Mutt/1.5.6i Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jul 07, 2004 at 02:54:16PM -0700, Greg KH wrote: > On Tue, Jul 06, 2004 at 12:11:19PM -0400, Alan Stern wrote: > > Greg: > > > > As Andrew Morton has already spotted, I messed up the interpretation of > > the result codes from various _trylock() routines. I didn't notice that > > down_trylock() and down_read_trylock() use opposite conventions for > > indicating success! This patch fixes the incorrect interpretation of > > down_trylock(). That error may well be responsible for some of the > > problems cropping up recently with OHCI controllers. Please apply. > > Applied. > > But even with this patch, and Andrew's, I have a hang at boot with my > USB mouse plugged in (uhci system). If I remove the mouse, and then boot, it works just fine. I can then insert it and the drivers are loaded just fine too. Looks like a race on accessing usbfs and loading a driver at the same time, as the "cold-boot" code scans usbfs to determine what driver to load. thanks, greg k-h