Re: GCC 3.4 and broken inlining.

Andi Kleen
2004-07-09T21:54:28Z

> Runtime errors caused with gcc 3.4 are IMHO much worse than such a small
> improvement or three dozen compile errors with gcc 3.4 .

What runtime errors?

Actually requiring inlining is extremly rare and such functions should
get that an explicit always inline just for documentation purposes.
(another issue is not optimized away checks, but that shows at link time)

In the x86-64 case it was vsyscalls, in Nigel's case it was swsusp.
Both are quite exceptional in what they do.

> Wouldn't it be a better solution if you would audit the existing inlines
> in the kernel for abuse of inline and fix those instead?

I don't see any point in going through ~1.2MLOC of code by hand
when a compiler can do it for me.

-Andi