public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <greg@kroah.com>
To: Andrew Morton <akpm@osdl.org>
Cc: Jesse Stockall <stockall@magma.ca>,
	s.rivoir@gts.it, linux-kernel@vger.kernel.org,
	stern@rowland.harvard.edu
Subject: Re: 2.6.7-mm7
Date: Fri, 9 Jul 2004 15:21:54 -0700	[thread overview]
Message-ID: <20040709222154.GC6284@kroah.com> (raw)
In-Reply-To: <20040709130045.211b6d50.akpm@osdl.org>

On Fri, Jul 09, 2004 at 01:00:45PM -0700, Andrew Morton wrote:
> Jesse Stockall <stockall@magma.ca> wrote:
> >
> > On Fri, 2004-07-09 at 14:54, Andrew Morton wrote:
> >                        down_write_trylock(&usb_all_devices_rwsem));
> >  > 
> >  > That's a bit unusual.  Could you (or Alan) please explain the reason for
> >  > this a little more?
> > 
> >  I believe you want this thread
> > 
> >  http://marc.theaimsgroup.com/?l=linux-usb-devel&m=108923404032264&w=2
> 
> Oh, OK.  Recursively taking an rwsem for reading is certainly deadlocky. 
> The main reason for not supporting this is that heavy down_read() traffic
> can trivially livelock down_write() waiters.  Alan's patch will introduce
> that shortcoming.
> 
> Really, it would be better to get the locking sorted out.

I agree, and we will before submitting the code to Linus.

thanks,

greg k-h

  reply	other threads:[~2004-07-09 22:23 UTC|newest]

Thread overview: 46+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-07-09  6:50 2.6.7-mm7 Andrew Morton
2004-07-09  8:15 ` 2.6.7-mm7 Stefano Rivoir
2004-07-09  9:41   ` 2.6.7-mm7 Andrew Morton
2004-07-09 10:27     ` 2.6.7-mm7 Stefano Rivoir
2004-07-09 10:32       ` 2.6.7-mm7 Stefano Rivoir
2004-07-09 11:45       ` 2.6.7-mm7 Jesse Stockall
2004-07-09 18:54         ` 2.6.7-mm7 Andrew Morton
2004-07-09 19:52           ` 2.6.7-mm7 Jesse Stockall
2004-07-09 20:00             ` 2.6.7-mm7 Andrew Morton
2004-07-09 22:21               ` Greg KH [this message]
2004-07-09 19:56           ` 2.6.7-mm7 Alan Stern
2004-07-09 10:32 ` 2.6.7-mm7 Jurgen Kramer
2004-07-09 10:39   ` 2.6.7-mm7 Andrew Morton
2004-07-09 11:16     ` 2.6.7-mm7 Jurgen Kramer
2004-07-09 14:40   ` 2.6.7-mm7 Felipe Alfaro Solana
2004-07-09 16:40     ` 2.6.7-mm7 Jurgen Kramer
2004-07-09 11:44 ` 2.6.7-mm7 Michael Geithe
2004-07-09 22:15   ` 2.6.7-mm7 Greg KH
2004-07-10  0:07     ` 2.6.7-mm7 Michael Geithe
2004-07-09 20:38 ` 2.6.7-mm7 Joseph Fannin
2004-07-09 21:11   ` 2.6.7-mm7 Andrew Morton
2004-07-14 22:01     ` 2.6.7-mm7 Tom Rini
2004-07-17 16:17     ` 2.6.7-mm7 Paul Mackerras
2004-07-17 19:19       ` 2.6.7-mm7 Joseph Fannin
2004-07-09 21:04 ` 2.6.7-mm7 William Lee Irwin III
2004-07-09 22:11   ` 2.6.7-mm7 William Lee Irwin III
2004-07-09 22:14   ` 2.6.7-mm7 Andrew Morton
2004-07-09 22:24     ` 2.6.7-mm7 James Bottomley
2004-07-09 23:40       ` 2.6.7-mm7 Andrew Morton
2004-07-10  2:47         ` 2.6.7-mm7 James Bottomley
2004-07-10  4:34 ` 2.6.7-mm7 Joshua Kwan
2004-07-10  4:40   ` 2.6.7-mm7 Joshua Kwan
2004-07-10 18:29 ` 2.6.7-mm7 Diego Calleja García
2004-07-10 20:04 ` 2.6.7-mm7 Marcin Gibuła
2004-07-10 20:10   ` 2.6.7-mm7 Marcin Gibuła
2004-07-10 20:27   ` 2.6.7-mm7 Andrew Morton
2004-07-10 20:32     ` 2.6.7-mm7 Marcin Gibuła
2004-07-11  4:19 ` 2.6.7-mm7 Dax Kelson
2004-07-11  4:40   ` 2.6.7-mm7 Andrew Morton
  -- strict thread matches above, loose matches on Subject: below --
2004-07-10  6:21 2.6.7-mm7 Zoltan Boszormenyi
     [not found] <A6974D8E5F98D511BB910002A50A6647615FFB70@hdsmsx403.hd.intel.com>
2004-07-11  2:23 ` 2.6.7-mm7 Len Brown
2004-07-11 10:23   ` 2.6.7-mm7 Thomas Svedberg
2004-07-11 15:49     ` 2.6.7-mm7 Zoltan Boszormenyi
     [not found] <A6974D8E5F98D511BB910002A50A6647615FFA5D@hdsmsx403.hd.intel.com>
2004-07-11  2:34 ` 2.6.7-mm7 Len Brown
2004-07-11 18:32   ` 2.6.7-mm7 Michael Geithe
     [not found] <A6974D8E5F98D511BB910002A50A6647615FFA8A@hdsmsx403.hd.intel.com>
2004-07-11  2:36 ` 2.6.7-mm7 Len Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20040709222154.GC6284@kroah.com \
    --to=greg@kroah.com \
    --cc=akpm@osdl.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=s.rivoir@gts.it \
    --cc=stern@rowland.harvard.edu \
    --cc=stockall@magma.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox