From: "Antonino A. Daplas" <adaplas@hotpop.com>
To: Guido Guenther <agx@sigxcpu.org>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: Linux Kernel list <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@osdl.org>
Subject: Re: [Patch]: Fix rivafb's NV_ARCH_, cleanup DEBUG, backlight control on ppc
Date: Sat, 10 Jul 2004 05:33:56 +0800 [thread overview]
Message-ID: <200407100533.59503.adaplas@hotpop.com> (raw)
In-Reply-To: <20040709112539.GA2286@bogon.ms20.nix>
On Friday 09 July 2004 19:25, Guido Guenther wrote:
> On Mon, Jun 21, 2004 at 10:36:44AM -0500, Benjamin Herrenschmidt wrote:
> > Ok, well, it looks good to me. There is no active maintainer for rivafb
> > so, I suppose if nobody complains of breakage, it should be fine.
>
> Since this isn't in yet. Here's another version that:
> - fixes the PCI-IDs (needed to get it to work on at least the NV17)
> - cleans up the DEBUG option (similar to the new radeonfb). This also
> makes it easy to replace printk by btext_printf() (on ppc) or similar
> to ease debugging of the fb code when all else fails.
> - adds backlight control for Apple powerbooks
> Patch is against 2.6.7-bk20. Please apply,
> -- Guido
Tried the patch, and works okay for me (NV10 x86). I'm not really too
keen on making debug printing as a kernel config option, but it's a minor point.
This patch should be applied.
Tony
next prev parent reply other threads:[~2004-07-09 21:34 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-06-01 4:16 [Patch]: Fix rivafb's OF parsing Guido Guenther
2004-06-01 4:28 ` Benjamin Herrenschmidt
2004-06-01 13:53 ` Guido Guenther
2004-06-02 9:57 ` Herbert Xu
2004-06-03 22:40 ` Benjamin Herrenschmidt
2004-06-04 15:49 ` Guido Guenther
2004-06-16 7:03 ` [Patch]: Fix rivafb's NV_ARCH_ Guido Guenther
2004-06-20 19:25 ` Guido Guenther
2004-06-20 22:05 ` Giuseppe Bilotta
2004-06-21 4:11 ` Benjamin Herrenschmidt
2004-06-21 7:11 ` Guido Guenther
2004-06-21 15:36 ` Benjamin Herrenschmidt
2004-06-21 19:51 ` Guido Guenther
2004-07-09 11:25 ` [Patch]: Fix rivafb's NV_ARCH_, cleanup DEBUG, backlight control on ppc Guido Guenther
2004-07-09 21:33 ` Antonino A. Daplas [this message]
2004-06-23 19:35 ` [Patch]: Fix rivafb's NV_ARCH_ jsimmons
2004-06-24 6:55 ` Guido Guenther
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200407100533.59503.adaplas@hotpop.com \
--to=adaplas@hotpop.com \
--cc=adaplas@pol.net \
--cc=agx@sigxcpu.org \
--cc=akpm@osdl.org \
--cc=benh@kernel.crashing.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox