Re: [ck] Re: [announce] [patch] Voluntary Kernel Preemption Patch

[Ingo Molnar <mingo@elte.hu>]

[-- Attachment #1: Type: text/plain, Size: 1424 bytes --]


* Con Kolivas <kernel@kolivas.org> wrote:

> Ok I've done one better than that ;) I had wli help make some
> instrumentation for me to help find the remaining non preemptible
> kernel portions and set the cutoff to 2ms. Here is what I found:
> 
> 7ms non-preemptible critical section violated 2 ms preempt threshold 
> starting at reiserfs_sync_fs+0x2d/0xc2 and ending at reiser
> fs_lookup+0xe2/0x221
> 
> 9ms non-preemptible critical section violated 2 ms preempt threshold 
> starting at reiserfs_dirty_inode+0x37/0x10e and ending at r
> eiserfs_dirty_inode+0xb0/0x10e
> 
> These seem to be the two offenders. Hope this helps.

great!

meanwhile i spent an afternoon with another latency testing suite:

  http://www.alsa-project.org/~iwai/latencytest-0.5.3.tar.gz

it was reporting more accurate latencies, except that there were strange
spikes of latencies. It turned out that for whatever reason, userspace
RDTSC is not always reliable on my box (!).

I've attached two fixes against latencytest - one makes rdtsc timestamps
more reliable, the other one fixes an SMP bug in the kernel module (it
would lock up under SMP otherwise.).

here's a latencytest QuickStart: 'cd latencytest; make', then
'insmod kernel/latency-test.ko', then 'cd tests; ../bin/run_tests'.  

Assuming you have RTC and audio enabled in your kernel it should work 
fine. It produces PNGs in the same format as Benno's latencytest suite.

	Ingo

[-- Attachment #2: latencytest-fixes.diff --]
[-- Type: text/plain, Size: 1048 bytes --]

--- latencytest/kernel/latencytest.c.orig	2004-07-11 12:29:30.000000000 +0200
+++ latencytest/kernel/latencytest.c	2004-07-11 16:29:48.883109752 +0200
@@ -41,7 +41,7 @@ static void my_interrupt(void *private_d
 	spin_lock(&my_lock);
 	count++;
 	if (count < irq_count)
-		return;
+		goto out_unlock;
 	count = 0;
 	if (irq_info.processed < MAX_PROC_CNTS) {
 		int i;
@@ -69,6 +69,7 @@ static void my_interrupt(void *private_d
 	}
 	irq_info.processed++;
 	wake_up(&my_sleep);
+out_unlock:
 	spin_unlock(&my_lock);
 }
 
--- latencytest/src/measure.c.orig	2004-07-11 14:20:57.000000000 +0200
+++ latencytest/src/measure.c	2004-07-11 16:25:32.375104896 +0200
@@ -35,9 +35,13 @@ static FILE *profile_fd;
 
 static inline unsigned long long int rdtsc(void)
 {
-	unsigned long long int x;
-	__asm__ volatile ("rdtsc" : "=A" (x));
-	return x;
+	unsigned long long int x, y;
+	for (;;) {
+		__asm__ volatile ("rdtsc" : "=A" (x));
+		__asm__ volatile ("rdtsc" : "=A" (y));
+		if (y - x < 1000)
+			return y;
+	}
 }
 
 static unsigned long long time_offset;