public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Matt Domsch <Matt_Domsch@dell.com>
To: "Randy.Dunlap" <rddunlap@osdl.org>
Cc: Linus Torvalds <torvalds@osdl.org>,
	linux-kernel@vger.kernel.org, akpm <akpm@osdl.org>
Subject: Re: [PATCH] edd (Re: Linux 2.6.8-rc1)
Date: Sun, 11 Jul 2004 23:49:46 -0500	[thread overview]
Message-ID: <20040712044946.GA21325@lists.us.dell.com> (raw)
In-Reply-To: <20040711160019.00c2d658.rddunlap@osdl.org>

[-- Attachment #1: Type: text/plain, Size: 891 bytes --]

On Sun, Jul 11, 2004 at 04:00:19PM -0700, Randy.Dunlap wrote:
> drivers/built-in.o: In function `edd_has_mbr_signature':
> drivers/built-in.o(.text+0x13b84f): undefined reference to `edd'
> drivers/built-in.o(.init.text+0xd39c): more undefined references to `edd' follow
> 
> CONFIG_EDD=y on X86o
> 
> 'edd' needs to be exported for drivers/firmware/edd.c

I don't think so.  It only needs be exported if a module is going to
use it.  Since you're building it in, not as a module, it should be
fine.

My own 'make defconfig' on a clean BK tree, enabling CONFIG_EDD=y,
links correctly.  Perhaps a make mrproper; make would be in order, as the
deps stage should have caught it for you...

Thanks,
Matt

-- 
Matt Domsch
Sr. Software Engineer, Lead Engineer
Dell Linux Solutions linux.dell.com & www.dell.com/linux
Linux on Dell mailing lists @ http://lists.us.dell.com

[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]

  parent reply	other threads:[~2004-07-12  4:49 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-07-11 18:29 Linux 2.6.8-rc1 Linus Torvalds
2004-07-11 23:00 ` [PATCH] edd (Re: Linux 2.6.8-rc1) Randy.Dunlap
2004-07-12  3:02   ` Adrian Bunk
2004-07-12  4:49   ` Matt Domsch [this message]
2004-07-12  5:21     ` Randy.Dunlap
2004-07-12  9:26 ` Linux 2.6.8-rc1 Matthias Andree
2004-07-12 18:54   ` Martin Schlemmer
2004-07-12  9:34 ` Paolo Ciarrocchi
2004-07-12 15:42   ` Adrian Bunk
2004-07-12 15:56     ` Paolo Ciarrocchi
2004-07-12 16:34       ` Adrian Bunk
2004-07-12 16:43         ` Linus Torvalds
2004-07-12 20:28           ` Paolo Ciarrocchi
2004-07-12 20:22         ` Paolo Ciarrocchi
2004-07-13 20:54       ` cliff white
2004-07-12 21:08     ` Horst von Brand
2004-07-12 11:30 ` is_highmem() and WANT_PAGE_VIRTUAL (was: Re: Linux 2.6.8-rc1) Geert Uytterhoeven
2004-07-12 13:51   ` Andy Whitcroft
2004-07-12 14:23     ` Geert Uytterhoeven
2004-07-12 12:01 ` Linux 2.6.8-rc1 Geert Uytterhoeven
2004-07-12 13:18   ` OGAWA Hirofumi
2004-07-12 13:25     ` Geert Uytterhoeven
2004-07-12 14:02       ` OGAWA Hirofumi
2004-07-12 13:23 ` struct_cpy() and kAFS (was: Re: Linux 2.6.8-rc1) Geert Uytterhoeven
2004-07-12 18:11   ` Andrew Morton
2004-07-12 18:23     ` Christoph Hellwig
2004-07-12 18:40       ` Andrew Morton
2004-07-13 10:14     ` David Howells
2004-07-12 23:49 ` Linux 2.6.8-rc1 (compile stats) John Cherry

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20040712044946.GA21325@lists.us.dell.com \
    --to=matt_domsch@dell.com \
    --cc=akpm@osdl.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rddunlap@osdl.org \
    --cc=torvalds@osdl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox