From: Andrew Morton <akpm@osdl.org>
To: Russell King <rmk+lkml@arm.linux.org.uk>
Cc: torvalds@osdl.org, linux-kernel@vger.kernel.org,
Vojtech Pavlik <vojtech@suse.cz>
Subject: Re: [PATCH] Update pcips2 driver
Date: Mon, 12 Jul 2004 13:25:25 -0700 [thread overview]
Message-ID: <20040712132525.550bcebb.akpm@osdl.org> (raw)
In-Reply-To: <20040712154207.A15469@flint.arm.linux.org.uk>
Russell King <rmk+lkml@arm.linux.org.uk> wrote:
>
> Use pci_request_regions()/pci_release_regions() instead of
> request_region()/release_region()
Some of this patch is already in Vojtech's tree. If it's not critical,
perhaps it would be best if he took the remaining bit:
From: Russell King <rmk+lkml@arm.linux.org.uk>
Use pci_request_regions()/pci_release_regions() instead of
request_region()/release_region()
Signed-off-by: Russell King <rmk@arm.linux.org.uk>
Signed-off-by: Andrew Morton <akpm@osdl.org>
---
25-akpm/./drivers/input/serio/pcips2.c | 8 +++-----
1 files changed, 3 insertions(+), 5 deletions(-)
diff -puN ./drivers/input/serio/pcips2.c~update-pcips2-driver ./drivers/input/serio/pcips2.c
--- 25/./drivers/input/serio/pcips2.c~update-pcips2-driver Mon Jul 12 13:25:01 2004
+++ 25-akpm/./drivers/input/serio/pcips2.c Mon Jul 12 13:25:01 2004
@@ -134,13 +134,11 @@ static int __devinit pcips2_probe(struct
ret = pci_enable_device(dev);
if (ret)
- return ret;
+ goto out;
- if (!request_region(pci_resource_start(dev, 0),
- pci_resource_len(dev, 0), "pcips2")) {
- ret = -EBUSY;
+ ret = pci_request_regions(dev, "pcips2");
+ if (ret)
goto disable;
- }
ps2if = kmalloc(sizeof(struct pcips2_data), GFP_KERNEL);
serio = kmalloc(sizeof(struct serio), GFP_KERNEL);
_
next prev parent reply other threads:[~2004-07-12 20:24 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-07-12 14:42 [PATCH] Update pcips2 driver Russell King
2004-07-12 20:25 ` Andrew Morton [this message]
2004-07-12 21:55 ` Russell King
2004-07-13 11:55 ` Vojtech Pavlik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040712132525.550bcebb.akpm@osdl.org \
--to=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rmk+lkml@arm.linux.org.uk \
--cc=torvalds@osdl.org \
--cc=vojtech@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox