From: Adrian Bunk <bunk@fs.tum.de>
To: bcollins@debian.org
Cc: linux1394-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org
Subject: [2.6 patch] eth1394: remove an inline
Date: Tue, 13 Jul 2004 02:27:20 +0200 [thread overview]
Message-ID: <20040713002720.GD4701@fs.tum.de> (raw)
Trying to compile drivers/ieee1394/eth1394.c with gcc 3.4 and
# define inline __inline__ __attribute__((always_inline))
results in the following compile error:
<-- snip -->
...
CC drivers/ieee1394/eth1394.o
drivers/ieee1394/eth1394.c: In function `eth1394_remove':
drivers/ieee1394/eth1394.c:189: sorry, unimplemented: inlining failed in
call to 'purge_partial_datagram': function body not available
drivers/ieee1394/eth1394.c:403: sorry, unimplemented: called from here
make[2]: *** [drivers/ieee1394/eth1394.o] Error 1
<-- snip -->
The patch below removes the purge_partial_datagram inline from eth1394.c .
An alternative approach to removing the inline would be to move the
function above the first function calling it.
diffstat output:
drivers/ieee1394/eth1394.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
Signed-off-by: Adrian Bunk <bunk@fs.tum.de>
--- linux-2.6.7-mm7-full-gcc3.4/drivers/ieee1394/eth1394.c.old 2004-07-13 02:21:05.000000000 +0200
+++ linux-2.6.7-mm7-full-gcc3.4/drivers/ieee1394/eth1394.c 2004-07-13 02:23:35.000000000 +0200
@@ -186,7 +186,7 @@
unsigned char * haddr);
static int ether1394_mac_addr(struct net_device *dev, void *p);
-static inline void purge_partial_datagram(struct list_head *old);
+static void purge_partial_datagram(struct list_head *old);
static int ether1394_tx(struct sk_buff *skb, struct net_device *dev);
static void ether1394_iso(struct hpsb_iso *iso);
@@ -1081,7 +1081,7 @@
return 0;
}
-static inline void purge_partial_datagram(struct list_head *old)
+static void purge_partial_datagram(struct list_head *old)
{
struct partial_datagram *pd = list_entry(old, struct partial_datagram, list);
struct list_head *lh, *n;
next reply other threads:[~2004-07-13 0:30 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-07-13 0:27 Adrian Bunk [this message]
2004-07-13 3:41 ` [2.6 patch] eth1394: remove an inline Steve Kinneberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040713002720.GD4701@fs.tum.de \
--to=bunk@fs.tum.de \
--cc=bcollins@debian.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux1394-devel@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox