From: Andi Kleen <ak@muc.de>
To: "Blackwood, John" <john.blackwood@ccur.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] arch/i386|x86_64/kernel/ptrace.c linux-2.6.7
Date: 13 Jul 2004 09:42:55 +0200
Date: Tue, 13 Jul 2004 09:42:55 +0200 [thread overview]
Message-ID: <20040713074254.GA41931@muc.de> (raw)
In-Reply-To: <40F33B35.3020209@ccur.com>
On Mon, Jul 12, 2004 at 09:30:29PM -0400, Blackwood, John wrote:
> > returned
> > value into 'ret' from the __put_user() or __get_user() calls, in the
> > same way that the arch/x86_64/ia32/ptrace32.c code does.
> >
> > Additionally, for x86_64 only, the access_ok() size parameter should
> > really
> > be sizeof(struct user_regs_struct) instead of FRAME_SIZE, since on
> > x86_64
> > the user_regs_struct being read/written is actually a bit larger than
> > the FRAME_SIZE define.
> >
> >
> > Thank you.
> >
> Sorry, I guess my diffs got new-line-botched-up.
>
> I'll try again:
The newlines were still broken, but I applied the x86-64 part by
hand. Thanks. For i386 I guess Andrew will queue it up.
-Andi
next prev parent reply other threads:[~2004-07-13 7:42 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-07-13 1:30 [PATCH] arch/i386|x86_64/kernel/ptrace.c linux-2.6.7 Blackwood, John
2004-07-13 7:42 ` Andi Kleen [this message]
-- strict thread matches above, loose matches on Subject: below --
2004-07-13 16:31 Blackwood, John
2004-07-13 18:31 ` Olaf Hering
2004-07-12 23:52 Blackwood, John
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040713074254.GA41931@muc.de \
--to=ak@muc.de \
--cc=john.blackwood@ccur.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox