From: Russell King <rmk+lkml@arm.linux.org.uk>
To: Hugang <hugang@soulinfo.com>
Cc: linux-kernel@vger.kernel.org, bcollins@debian.org
Subject: Re: [PATCH] fix rmmod sbp2 hang in 2.6.7
Date: Wed, 14 Jul 2004 10:24:17 +0100 [thread overview]
Message-ID: <20040714102417.A12942@flint.arm.linux.org.uk> (raw)
In-Reply-To: <20040714171107.49aa64f7@localhost>; from hugang@soulinfo.com on Wed, Jul 14, 2004 at 05:11:07PM +0800
On Wed, Jul 14, 2004 at 05:11:07PM +0800, Hugang wrote:
> On Wed, 14 Jul 2004 16:13:57 +0800
> Hugang <hugang@soulinfo.com> wrote:
> | On Wed, 14 Jul 2004 11:48:54 +0800
> | Hugang <hugang@soulinfo.com> wrote:
> |
> ....
> | Sorry, the above patch, can't fix rmmod sbp2 complete,I still got hang when
> | rmmod sbp2 in my PowerBook G4 sometimes.
> |
>
> This new patch can complete fix the bug. That's really hack. Any comment are
> welcome.
This down+up prevents drivers from being unloaded until there are no
references to their struct device_driver. By removing this, you open
the very real possibility for an oops to occur.
If you're waiting inside that function for the last reference to be
dropped, the real question is why you still have references to it.
--
Russell King
Linux kernel 2.6 ARM Linux - http://www.arm.linux.org.uk/
maintainer of: 2.6 PCMCIA - http://pcmcia.arm.linux.org.uk/
2.6 Serial core
next prev parent reply other threads:[~2004-07-14 9:24 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-07-14 3:48 [PATCH] fix rmmod sbp2 hang in 2.6.7 Hugang
2004-07-14 8:13 ` Hugang
2004-07-14 9:11 ` Hugang
2004-07-14 9:24 ` Russell King [this message]
2004-07-14 9:29 ` Hugang
2004-07-14 10:20 ` Russell King
2004-07-14 11:33 ` Ben Collins
2004-07-17 18:43 ` Tim Wright
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040714102417.A12942@flint.arm.linux.org.uk \
--to=rmk+lkml@arm.linux.org.uk \
--cc=bcollins@debian.org \
--cc=hugang@soulinfo.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox