Re: [PATCH][2.6.8-rc1-mm1] drivers/scsi/sg.c gcc341 inlining fix

[Adrian Bunk <bunk@fs.tum.de>]

On Wed, Jul 14, 2004 at 12:44:44PM -0400, Jeff Garzik wrote:
> Adrian Bunk wrote:
> >On Wed, Jul 14, 2004 at 11:52:46AM -0400, Jeff Garzik wrote:
> >
> >>...
> >>If gcc is insisting that prototypes for inlines no longer work, we have 
> >>a lot of code churn on our hands ;-(  Grumble.
> >
> >
> >I've counted at about 30 files with such problems in a full i386 
> >2.6.7-mm7 compile.
> >
> >I've already sent patches for some of them (e.g. the dmascc.c one), and 
> >they are usually pretty straightforward.
> 
> This is not a problem with the kernel.
> 
> All these files have been functioning just fine for years, with properly 
> prototyped static inline functions.

Add -Winline to the compile flags, and name one gcc version that is able 
to inline them all in sg.c ...

> Though there is a the claim that '#define inline always_inline' is 
> leading to all this breakage.

gcc 3.4 is just complaining louder that it can't inline something it was 
told to inline.

> 	Jeff

cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed