From: Himanshu Raj <rhim@cc.gatech.edu>
To: trivial@rustcorp.com.au
Cc: linux-kernel@vger.kernel.org
Subject: A trivial patch for removing unnecessary comment in mm/filemap.c
Date: Wed, 14 Jul 2004 19:39:40 -0400 [thread overview]
Message-ID: <20040714233940.GA8289@cc.gatech.edu> (raw)
[-- Attachment #1: Type: text/plain, Size: 520 bytes --]
Hi,
This patch removes some unnecessary comments in mm/filemap.c in function find_get_page. First, there is no
longer a hash list being used, second the lock being used is the same for search as well as addition/removal.
Thanks,
Himanshu
--
-------------------------------------------------------------------------
Himanshu Raj
PhD Student, GaTech (www.cc.gatech.edu/~rhim)
I prefer to receive attachments in an open, non-proprietary format.
-------------------------------------------------------------------------
[-- Attachment #2: patch_useless_comment --]
[-- Type: text/plain, Size: 418 bytes --]
--- linux-2.6.8-rc1-old/mm/filemap.c 2004-07-14 19:29:53.757633968 -0400
+++ linux-2.6.8-rc1/mm/filemap.c 2004-07-14 19:30:05.365869248 -0400
@@ -440,10 +440,6 @@
{
struct page *page;
- /*
- * We scan the hash list read-only. Addition to and removal from
- * the hash-list needs a held write-lock.
- */
spin_lock_irq(&mapping->tree_lock);
page = radix_tree_lookup(&mapping->page_tree, offset);
if (page)
reply other threads:[~2004-07-14 23:41 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040714233940.GA8289@cc.gatech.edu \
--to=rhim@cc.gatech.edu \
--cc=linux-kernel@vger.kernel.org \
--cc=trivial@rustcorp.com.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox