From: Adrian Bunk <bunk@fs.tum.de>
To: Denis Vlasenko <vda@port.imtp.ilyichevsk.odessa.ua>
Cc: cramerj@intel.com, john.ronciak@intel.com,
ganesh.venkatesan@intel.com, linux-kernel@vger.kernel.org,
linux-net@vger.kernel.org
Subject: Re: [2.6 patch] e1000_main.c: fix inline compile errors
Date: Thu, 15 Jul 2004 21:46:23 +0200 [thread overview]
Message-ID: <20040715194623.GD25633@fs.tum.de> (raw)
In-Reply-To: <200407151213.59568.vda@port.imtp.ilyichevsk.odessa.ua>
On Thu, Jul 15, 2004 at 12:13:59PM +0300, Denis Vlasenko wrote:
>...
> As you go thru them, consider removing inline keyword for
> such large functions.
>...
I did propose this as an alternative approach in the text that
accopagnied the patch.
My main reason for not directly proposing to remove the inlines was the
fact that all inline functions were either very small or called only
once.
cu
Adrian
--
"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed
next prev parent reply other threads:[~2004-07-15 19:46 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-07-14 21:01 [2.6 patch] e1000_main.c: fix inline compile errors Adrian Bunk
2004-07-15 9:13 ` Denis Vlasenko
2004-07-15 19:46 ` Adrian Bunk [this message]
[not found] ` <200407152326.40331.vda@port.imtp.ilyichevsk.odessa.ua>
2004-07-15 20:49 ` Adrian Bunk
[not found] ` <200407160010.49701.vda@port.imtp.ilyichevsk.odessa.ua>
2004-07-17 13:18 ` Adrian Bunk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040715194623.GD25633@fs.tum.de \
--to=bunk@fs.tum.de \
--cc=cramerj@intel.com \
--cc=ganesh.venkatesan@intel.com \
--cc=john.ronciak@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-net@vger.kernel.org \
--cc=vda@port.imtp.ilyichevsk.odessa.ua \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox