From: "George G. Davis" <gdavis@mvista.com>
To: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Allow `make O=<obj> {cscope,tags}` to work
Date: Mon, 19 Jul 2004 14:29:25 -0400 [thread overview]
Message-ID: <20040719182925.GC1890@mvista.com> (raw)
In-Reply-To: <20040719173654.GB1890@mvista.com>
On Mon, Jul 19, 2004 at 01:36:54PM -0400, George G. Davis wrote:
> On Mon, Jul 19, 2004 at 09:24:30PM +0200, sam@ravnborg.org wrote:
> > On Mon, Jul 19, 2004 at 01:17:59PM -0400, George G. Davis wrote:
>
> <snip>
>
> > > endef
> > >
> > > -quiet_cmd_cscope-file = FILELST cscope.files
> > > - cmd_cscope-file = $(all-sources) > cscope.files
> > > +quiet_cmd_cscope-file = FILELST $(obj)/cscope.files
> > > + cmd_cscope-file = $(all-sources) > $(obj)/cscope.files
> > The $(obj) in this line should not be needed. Current directory
> > defaults to $(obj) equals $(objtree) when executing make cscope.
>
> Yep, I got carried away there, Thanks. Should I resubmit a revised patch?
Ok, after clutzing about with bk fix, etc., here's the revised patch:
# This is a BitKeeper generated diff -Nru style patch.
#
# ChangeSet
# 2004/07/19 14:24:28-04:00 gdavis@davisg.ne.client2.attbi.com
# Makefile:
# Allow `make O=<obj> {cscope,tags}` to work
#
# Makefile
# 2004/07/19 14:17:25-04:00 gdavis@davisg.ne.client2.attbi.com +6 -6
# Allow `make O=<obj> {cscope,tags}` to work
#
diff -Nru a/Makefile b/Makefile
--- a/Makefile 2004-07-19 14:24:43 -04:00
+++ b/Makefile 2004-07-19 14:24:43 -04:00
@@ -1009,19 +1009,19 @@
# ---------------------------------------------------------------------------
define all-sources
- ( find . $(RCS_FIND_IGNORE) \
+ ( find $(srctree) $(RCS_FIND_IGNORE) \
\( -name include -o -name arch \) -prune -o \
-name '*.[chS]' -print; \
- find arch/$(ARCH) $(RCS_FIND_IGNORE) \
+ find $(srctree)/arch/$(ARCH) $(RCS_FIND_IGNORE) \
-name '*.[chS]' -print; \
- find security/selinux/include $(RCS_FIND_IGNORE) \
+ find $(srctree)/security/selinux/include $(RCS_FIND_IGNORE) \
-name '*.[chS]' -print; \
- find include $(RCS_FIND_IGNORE) \
+ find $(srctree)/include $(RCS_FIND_IGNORE) \
\( -name config -o -name 'asm-*' \) -prune \
-o -name '*.[chS]' -print; \
- find include/asm-$(ARCH) $(RCS_FIND_IGNORE) \
+ find $(srctree)/include/asm-$(ARCH) $(RCS_FIND_IGNORE) \
-name '*.[chS]' -print; \
- find include/asm-generic $(RCS_FIND_IGNORE) \
+ find $(srctree)/include/asm-generic $(RCS_FIND_IGNORE) \
-name '*.[chS]' -print )
endef
--
Regards,
George
next prev parent reply other threads:[~2004-07-19 18:29 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-07-19 17:17 [PATCH] Allow `make O=<obj> {cscope,tags}` to work George G. Davis
2004-07-19 19:24 ` sam
2004-07-19 17:36 ` George G. Davis
2004-07-19 18:29 ` George G. Davis [this message]
2004-07-22 22:45 ` Sam Ravnborg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040719182925.GC1890@mvista.com \
--to=gdavis@mvista.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox