From: Marcelo Tosatti <marcelo.tosatti@cyclades.com>
To: Adrian Bunk <bunk@fs.tum.de>
Cc: Krzysztof Rusocki <kszysiu@iceberg.elsat.net.pl>,
cltien@cmedia.com.tw, linux-kernel@vger.kernel.org
Subject: Re: [2.4 patch] cmpci oops on rmmod + fix
Date: Tue, 20 Jul 2004 11:52:42 -0300 [thread overview]
Message-ID: <20040720145242.GA2315@dmt.cyclades> (raw)
In-Reply-To: <20040717200704.GD14733@fs.tum.de>
On Sat, Jul 17, 2004 at 10:07:04PM +0200, Adrian Bunk wrote:
> Below is a patch originally sent against 2.6 by
> Krzysztof Rusocki <kszysiu@iceberg.elsat.net.pl> (and already included
> in 2.6.8-rc1).
>
> His explanation of the patch was:
>
> <-- snip -->
>
> The cmpci driver included in Linux 2.6.7 causes an oops on rmmod,
> I believe cm_remove should be marked __devexit rather than __devinit.
>
> <-- snip -->
>
>
> This is an obvious bug, and below is my backport of his fix to 2.4 .
> While I was editing struct cm_driver, I've also converted it to C99
> initializers (as already done in 2.6).
>
>
> Signed-off-by: Adrian Bunk <bunk@fs.tum.de>
Looks good, applied.
Thanks Adrian.
prev parent reply other threads:[~2004-07-20 16:05 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-07-17 20:07 [2.4 patch] cmpci oops on rmmod + fix Adrian Bunk
2004-07-20 14:52 ` Marcelo Tosatti [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040720145242.GA2315@dmt.cyclades \
--to=marcelo.tosatti@cyclades.com \
--cc=bunk@fs.tum.de \
--cc=cltien@cmedia.com.tw \
--cc=kszysiu@iceberg.elsat.net.pl \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox