From: Marcelo Tosatti <marcelo.tosatti@cyclades.com>
To: john stultz <johnstul@us.ibm.com>
Cc: Pete Zaitcev <zaitcev@redhat.com>,
lkml <linux-kernel@vger.kernel.org>,
vojtech@suse.cz
Subject: Re: [PATCH][2.4 Backport] x445 usb legacy fix
Date: Tue, 20 Jul 2004 15:17:00 -0300 [thread overview]
Message-ID: <20040720181700.GA2576@dmt.cyclades> (raw)
In-Reply-To: <1090344174.1388.471.camel@cog.beaverton.ibm.com>
On Tue, Jul 20, 2004 at 10:22:55AM -0700, john stultz wrote:
> On Mon, 2004-07-19 at 20:06, Pete Zaitcev wrote:
> > On Mon, 19 Jul 2004 19:07:03 -0700
> > john stultz <johnstul@us.ibm.com> wrote:
> >
> > The patch looks a little dirty in small places, e.g. the double
> > semicolon, the HZ/100 instead of HZ/10, space, two variables
> > named "base" in two blocks. I do not believe Vojtech wrote it.
> > He must have gotten it from someone else.
>
> The whitespace and double semicolon have been removed already. I'm not
> sure I follow the HZ/100 bit (as my understanding is 1/100'th of a
> second is the desired wait time). If you could clarify the error you
> see, I'll fix it and resend the patch.
>
> > But in any case, it's not something I can decide. Marcelo has that
> > power for stock kernels, and for Red Hat kernels there's a process
> > which starts with Bugzilla.
>
> I was under the impression you were the 2.4 USB maintainer. Am I
> misdirecting this patch?
No, you are sending to the right person, Pete is the v2.4 USB maintainer.
The most sensible thing to do seems to wait for this to get into v2.6
mainline, let it stabilize, and then include it in v2.4 (Greg suggested
this approach and I completly agree with him).
next prev parent reply other threads:[~2004-07-20 19:24 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-07-20 2:07 [PATCH][2.4 Backport] x445 usb legacy fix john stultz
2004-07-20 3:06 ` Pete Zaitcev
2004-07-20 5:13 ` Vojtech Pavlik
2004-07-20 5:51 ` Pete Zaitcev
2004-07-20 12:58 ` Vojtech Pavlik
2004-07-20 17:22 ` john stultz
2004-07-20 18:17 ` Marcelo Tosatti [this message]
[not found] ` <20040816113314.GD14159@logos.cnet>
[not found] ` <1092678515.2429.4.camel@cog.beaverton.ibm.com>
2004-08-25 16:53 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040720181700.GA2576@dmt.cyclades \
--to=marcelo.tosatti@cyclades.com \
--cc=johnstul@us.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=vojtech@suse.cz \
--cc=zaitcev@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox