From: Geert Uytterhoeven <geert@linux-m68k.org>
To: Linus Torvalds <torvalds@osdl.org>, Andrew Morton <akpm@osdl.org>
Cc: Linux Kernel Development <linux-kernel@vger.kernel.org>,
Geert Uytterhoeven <geert@linux-m68k.org>
Subject: [PATCH 464] m68k sparse void return
Date: Tue, 20 Jul 2004 20:38:00 +0200 [thread overview]
Message-ID: <200407201838.i6KIc0CG015389@anakin.of.borg> (raw)
M68k: Don't return anything in functions returning void (found by sparse)
Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
--- linux-2.6.8-rc2/arch/m68k/mac/macints.c 2004-05-24 11:13:22.000000000 +0200
+++ linux-m68k-2.6.8-rc2/arch/m68k/mac/macints.c 2004-07-10 21:06:54.000000000 +0200
@@ -545,7 +545,8 @@
#endif
if (irq < VIA1_SOURCE_BASE) {
- return cpu_free_irq(irq, dev_id);
+ cpu_free_irq(irq, dev_id);
+ return;
}
if (irq >= NUM_MAC_SOURCES) {
--- linux-2.6.8-rc2/arch/m68k/mm/kmap.c 2004-04-28 16:08:20.000000000 +0200
+++ linux-m68k-2.6.8-rc2/arch/m68k/mm/kmap.c 2004-07-10 21:06:54.000000000 +0200
@@ -45,7 +45,7 @@
static inline void free_io_area(void *addr)
{
- return vfree((void *)(PAGE_MASK & (unsigned long)addr));
+ vfree((void *)(PAGE_MASK & (unsigned long)addr));
}
#else
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
reply other threads:[~2004-07-20 18:38 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200407201838.i6KIc0CG015389@anakin.of.borg \
--to=geert@linux-m68k.org \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox