pci_bus_lock question

pci_bus_lock question

[John Rose]

Is the intended purpose of pci_bus_lock to synchronize access to _just_
the global list of pci devices, or also to the pci_root_buses list?

If it is intended to protect the latter, I see many unfortunate places
where it's not being used :)

Thanks-
John

Re: pci_bus_lock question

[John Rose]

But then, most of these violations are in __init functions.  I think I
just answered my own question :)

Thanks-
John

On Wed, 2004-07-21 at 17:10, John Rose wrote:
> Is the intended purpose of pci_bus_lock to synchronize access to _just_
> the global list of pci devices, or also to the pci_root_buses list?
> 
> If it is intended to protect the latter, I see many unfortunate places
> where it's not being used :)
> 
> Thanks-
> John

Re: pci_bus_lock question

[Greg KH]

On Wed, Jul 21, 2004 at 05:21:08PM -0500, John Rose wrote:
> But then, most of these violations are in __init functions.  I think I
> just answered my own question :)

Yes, we don't protect the lists in those __init functions, as it isn't
needed at that point in time.

thanks,

greg k-h

Re: pci_bus_lock question

[John Rose]

I need to remove a bus from the pci_root_buses() list, and I need to do
so from a module.  Would it be preferable to export the pci_bus_lock
symbol or create wrappers in the PCI core that safely add/remove buses
to/from this list?

I'm guessing the latter :)

Thanks-
John

On Thu, 2004-07-22 at 02:08, Greg KH wrote:
> On Wed, Jul 21, 2004 at 05:21:08PM -0500, John Rose wrote:
> > But then, most of these violations are in __init functions.  I think I
> > just answered my own question :)
> 
> Yes, we don't protect the lists in those __init functions, as it isn't
> needed at that point in time.
> 
> thanks,
> 
> greg k-h
> 

Re: pci_bus_lock question

[Greg KH]

On Thu, Jul 22, 2004 at 10:11:21AM -0500, John Rose wrote:
> I need to remove a bus from the pci_root_buses() list, and I need to do
> so from a module.  Would it be preferable to export the pci_bus_lock
> symbol or create wrappers in the PCI core that safely add/remove buses
> to/from this list?
> 
> I'm guessing the latter :)

Good guess :)

greg k-h