Re: [PATCH] consolidate sched domains

[Dimitri Sivanich <sivanich@sgi.com>]

On Fri, Jul 23, 2004 at 02:50:46PM -0700, Siddha, Suresh B wrote:
> On Friday 23 July 2004 08:30, Dimitri Sivanich wrote:
> > Do other architectures need to define their own cpu_sibling_maps, or am I
> > missing something that would define that for IA64 and others?
> 
> Nick means, all the architectures which use CONFIG_SCHED_SMT needs to define 
> cpu_sibling_map.
> 
> Nick, aren't you missing the attached fix in your patch?
> 
> thanks,
> suresh

Ok, but cpu_to_phys_group() does a lookup in cpu_sibling map:
__init static int cpu_to_phys_group(int cpu)
{
        return first_cpu(cpu_sibling_map[cpu]);
}

and is called from outside of a CONFIG_SCHED_SMT ifdef here:
                sd = &per_cpu(phys_domains, i);
==>             group = cpu_to_phys_group(i);
                *sd = SD_CPU_INIT;
                sd->span = nodemask;
                sd->parent = p;
                sd->groups = &sched_group_phys[group];

#ifdef CONFIG_SCHED_SMT
                p = sd;
                sd = &per_cpu(cpu_domains, i);
..