* Re: [Repost] IDE error 2.6.7-rc3-mm2 and 2.6.8-rc1-mm1 [not found] <200407220659.22948.tabris@tabriel.tabris.net> @ 2004-07-22 15:39 ` Jens Axboe 2004-07-23 10:14 ` tabris 2004-07-27 18:07 ` tabris 0 siblings, 2 replies; 6+ messages in thread From: Jens Axboe @ 2004-07-22 15:39 UTC (permalink / raw) To: Tabris; +Cc: linux-kernel On Thu, Jul 22 2004, Tabris wrote: > -----BEGIN PGP SIGNED MESSAGE----- > Hash: SHA1 > > Jul 21 03:00:18 tabriel kernel: hda: drive_cmd: status=0x51 { DriveReady > SeekComplete Error } > Jul 21 03:00:18 tabriel kernel: hda: drive_cmd: error=0x04 { > DriveStatusError } > Jul 21 03:00:18 tabriel kernel: ide: failed opcode was: 0xe7 > Jul 21 03:00:23 tabriel kernel: hda: drive_cmd: status=0x51 { DriveReady > SeekComplete Error } > Jul 21 03:00:23 tabriel kernel: hda: drive_cmd: error=0x04 { > DriveStatusError } > Jul 21 03:00:23 tabriel kernel: ide: failed opcode was: 0xe7 > Jul 21 03:00:28 tabriel kernel: hda: drive_cmd: status=0x51 { DriveReady > SeekComplete Error } > Jul 21 03:00:28 tabriel kernel: hda: drive_cmd: error=0x04 { > DriveStatusError } > Jul 21 03:00:28 tabriel kernel: ide: failed opcode was: 0xe7 > > This error did not occur in 2.6.6-rc3-mm2. Turning off ACPI made no > difference, not that I expected one. > > It appears to be harmless but it's polluting my syslog. > > Appears related to > http://marc.theaimsgroup.com/?l=linux-kernel&m=108946389700930 > > None of my harddrives are over 60GiB (and hda is an 8GiB), so there's > no reason i should be getting LBA48 Flush Cache. > > What should I do, what do you need from me to get to the bottom of > this? Does this work? --- /opt/kernel/linux-2.6.8-rc1-mm1/drivers/ide/ide-disk.c 2004-07-22 13:37:09.751485758 -0200 +++ linux-2.6.8-rc1-mm1/drivers/ide/ide-disk.c 2004-07-22 13:37:52.812593031 -0200 @@ -1248,7 +1248,8 @@ memset(rq->cmd, 0, sizeof(rq->cmd)); - if ((drive->id->cfs_enable_2 & 0x2400) == 0x2400) + if (ide_id_has_flush_cache_ext(drive->id) && + (drive->capacity64 >= (1UL << 28))) rq->cmd[0] = WIN_FLUSH_CACHE_EXT; else rq->cmd[0] = WIN_FLUSH_CACHE; --- /opt/kernel/linux-2.6.8-rc1-mm1/drivers/ide/ide-io.c 2004-07-22 13:37:09.756486583 -0200 +++ linux-2.6.8-rc1-mm1/drivers/ide/ide-io.c 2004-07-22 13:38:23.807708802 -0200 @@ -67,7 +67,8 @@ rq->buffer = buf; rq->buffer[0] = WIN_FLUSH_CACHE; - if (ide_id_has_flush_cache_ext(drive->id)) + if (ide_id_has_flush_cache_ext(drive->id) && + (drive->capacity64 >= (1UL << 28))) rq->buffer[0] = WIN_FLUSH_CACHE_EXT; } -- Jens Axboe ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Repost] IDE error 2.6.7-rc3-mm2 and 2.6.8-rc1-mm1 2004-07-22 15:39 ` [Repost] IDE error 2.6.7-rc3-mm2 and 2.6.8-rc1-mm1 Jens Axboe @ 2004-07-23 10:14 ` tabris 2004-07-27 18:07 ` tabris 1 sibling, 0 replies; 6+ messages in thread From: tabris @ 2004-07-23 10:14 UTC (permalink / raw) To: Jens Axboe; +Cc: linux-kernel On Thursday 22 July 2004 11:39 am, Jens Axboe wrote: > On Thu, Jul 22 2004, Tabris wrote: > > -----BEGIN PGP SIGNED MESSAGE----- > > Hash: SHA1 > > > > Jul 21 03:00:18 tabriel kernel: hda: drive_cmd: status=0x51 { > > DriveReady SeekComplete Error } > > Jul 21 03:00:18 tabriel kernel: hda: drive_cmd: error=0x04 { > > DriveStatusError } > > Jul 21 03:00:18 tabriel kernel: ide: failed opcode was: 0xe7 > > Jul 21 03:00:23 tabriel kernel: hda: drive_cmd: status=0x51 { > > DriveReady SeekComplete Error } > > Jul 21 03:00:23 tabriel kernel: hda: drive_cmd: error=0x04 { > > DriveStatusError } > > Jul 21 03:00:23 tabriel kernel: ide: failed opcode was: 0xe7 > > Jul 21 03:00:28 tabriel kernel: hda: drive_cmd: status=0x51 { > > DriveReady SeekComplete Error } > > Jul 21 03:00:28 tabriel kernel: hda: drive_cmd: error=0x04 { > > DriveStatusError } > > Jul 21 03:00:28 tabriel kernel: ide: failed opcode was: 0xe7 > > > > This error did not occur in 2.6.6-rc3-mm2. Turning off ACPI made > > no difference, not that I expected one. > > > > It appears to be harmless but it's polluting my syslog. > > > > Appears related to > > http://marc.theaimsgroup.com/?l=linux-kernel&m=108946389700930 > > > > None of my harddrives are over 60GiB (and hda is an 8GiB), so > > there's no reason i should be getting LBA48 Flush Cache. > > > > What should I do, what do you need from me to get to the bottom of > > this? > > Does this work? No, however it does seem to start it going in my syslog a bit earlier, but that may be meaningless (normally I found it waited until after qmail would start). Also, my i2c/sensors have stopped working (tho I doubt it has anything to do with your patch, it _does_ lineup with my applying your patch and rebooting...) -- tabris - Is it weird in here, or is it just me? -- Steven Wright ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Repost] IDE error 2.6.7-rc3-mm2 and 2.6.8-rc1-mm1 2004-07-22 15:39 ` [Repost] IDE error 2.6.7-rc3-mm2 and 2.6.8-rc1-mm1 Jens Axboe 2004-07-23 10:14 ` tabris @ 2004-07-27 18:07 ` tabris 2004-07-27 19:52 ` Jens Axboe 1 sibling, 1 reply; 6+ messages in thread From: tabris @ 2004-07-27 18:07 UTC (permalink / raw) To: Jens Axboe; +Cc: linux-kernel On Thursday 22 July 2004 11:39 am, Jens Axboe wrote: > On Thu, Jul 22 2004, Tabris wrote: > > -----BEGIN PGP SIGNED MESSAGE----- > > Hash: SHA1 <snip log> > > This error did not occur in 2.6.6-rc3-mm2. Turning off ACPI made > > no difference, not that I expected one. > > > > It appears to be harmless but it's polluting my syslog. > > > > Appears related to > > http://marc.theaimsgroup.com/?l=linux-kernel&m=108946389700930 > > > > None of my harddrives are over 60GiB (and hda is an 8GiB), so > > there's no reason i should be getting LBA48 Flush Cache. > > > > What should I do, what do you need from me to get to the bottom of > > this? > > Does this work? No, however it does seem to start it going in my syslog a bit earlier, but that may be meaningless (normally I found it waited until after qmail would start). Also, my i2c/sensors have stopped working (tho I doubt it has anything to do with your patch, it _does_ lineup with my applying your patch and rebooting...) -- tabris ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Repost] IDE error 2.6.7-rc3-mm2 and 2.6.8-rc1-mm1 2004-07-27 18:07 ` tabris @ 2004-07-27 19:52 ` Jens Axboe 2004-07-29 9:26 ` tabris 0 siblings, 1 reply; 6+ messages in thread From: Jens Axboe @ 2004-07-27 19:52 UTC (permalink / raw) To: tabris; +Cc: linux-kernel On Tue, Jul 27 2004, tabris wrote: > On Thursday 22 July 2004 11:39 am, Jens Axboe wrote: > > On Thu, Jul 22 2004, Tabris wrote: > > > -----BEGIN PGP SIGNED MESSAGE----- > > > Hash: SHA1 > <snip log> > > > This error did not occur in 2.6.6-rc3-mm2. Turning off ACPI made > > > no difference, not that I expected one. > > > > > > It appears to be harmless but it's polluting my syslog. > > > > > > Appears related to > > > http://marc.theaimsgroup.com/?l=linux-kernel&m=108946389700930 > > > > > > None of my harddrives are over 60GiB (and hda is an 8GiB), so > > > there's no reason i should be getting LBA48 Flush Cache. > > > > > > What should I do, what do you need from me to get to the bottom of > > > this? > > > > Does this work? > No, however it does seem to start it going in my syslog a bit earlier, > but that may be meaningless (normally I found it waited until after > qmail would start). Try this. --- /opt/kernel/linux-2.6.8-rc1-mm1/drivers/ide/ide-disk.c 2004-07-22 13:37:09.000000000 -0200 +++ linux-2.6.8-rc1-mm1/drivers/ide/ide-disk.c 2004-07-27 03:39:11.016545806 -0200 @@ -1248,7 +1248,8 @@ memset(rq->cmd, 0, sizeof(rq->cmd)); - if ((drive->id->cfs_enable_2 & 0x2400) == 0x2400) + if (ide_id_has_flush_cache_ext(drive->id) && + (drive->capacity64 >= (1UL << 28))) rq->cmd[0] = WIN_FLUSH_CACHE_EXT; else rq->cmd[0] = WIN_FLUSH_CACHE; @@ -1616,9 +1617,8 @@ * properly. We can safely support FLUSH_CACHE on lba48, if capacity * doesn't exceed lba28 */ - barrier = 1; + barrier = ide_id_has_flush_cache(id); if (drive->addressing == 1) { - barrier = ide_id_has_flush_cache(id); if (capacity > (1ULL << 28) && !ide_id_has_flush_cache_ext(id)) barrier = 0; } --- /opt/kernel/linux-2.6.8-rc1-mm1/drivers/ide/ide-io.c 2004-07-22 13:37:09.000000000 -0200 +++ linux-2.6.8-rc1-mm1/drivers/ide/ide-io.c 2004-07-22 13:38:23.000000000 -0200 @@ -67,7 +67,8 @@ rq->buffer = buf; rq->buffer[0] = WIN_FLUSH_CACHE; - if (ide_id_has_flush_cache_ext(drive->id)) + if (ide_id_has_flush_cache_ext(drive->id) && + (drive->capacity64 >= (1UL << 28))) rq->buffer[0] = WIN_FLUSH_CACHE_EXT; } -- Jens Axboe ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Repost] IDE error 2.6.7-rc3-mm2 and 2.6.8-rc1-mm1 2004-07-27 19:52 ` Jens Axboe @ 2004-07-29 9:26 ` tabris 2004-07-29 9:29 ` Jens Axboe 0 siblings, 1 reply; 6+ messages in thread From: tabris @ 2004-07-29 9:26 UTC (permalink / raw) To: Jens Axboe; +Cc: linux-kernel -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 On Tuesday 27 July 2004 3:52 pm, Jens Axboe wrote: > On Tue, Jul 27 2004, tabris wrote: > > On Thursday 22 July 2004 11:39 am, Jens Axboe wrote: > > > On Thu, Jul 22 2004, Tabris wrote: > > > > -----BEGIN PGP SIGNED MESSAGE----- > > > > Hash: SHA1 > > > > Try this. Works. I don't see the error in my syslog anymore. Thank you. Hopefully this fix will make it into -mm and/or mainline soon. > > --- /opt/kernel/linux-2.6.8-rc1-mm1/drivers/ide/ide-disk.c 2004-07-22 > 13:37:09.000000000 -0200 +++ > linux-2.6.8-rc1-mm1/drivers/ide/ide-disk.c 2004-07-27 > 03:39:11.016545806 -0200 @@ -1248,7 +1248,8 @@ > > memset(rq->cmd, 0, sizeof(rq->cmd)); > > - if ((drive->id->cfs_enable_2 & 0x2400) == 0x2400) > + if (ide_id_has_flush_cache_ext(drive->id) && > + (drive->capacity64 >= (1UL << 28))) > rq->cmd[0] = WIN_FLUSH_CACHE_EXT; > else > rq->cmd[0] = WIN_FLUSH_CACHE; > @@ -1616,9 +1617,8 @@ > * properly. We can safely support FLUSH_CACHE on lba48, if > capacity * doesn't exceed lba28 > */ > - barrier = 1; > + barrier = ide_id_has_flush_cache(id); > if (drive->addressing == 1) { > - barrier = ide_id_has_flush_cache(id); > if (capacity > (1ULL << 28) && !ide_id_has_flush_cache_ext(id)) > barrier = 0; > } > --- /opt/kernel/linux-2.6.8-rc1-mm1/drivers/ide/ide-io.c 2004-07-22 > 13:37:09.000000000 -0200 +++ > linux-2.6.8-rc1-mm1/drivers/ide/ide-io.c 2004-07-22 > 13:38:23.000000000 -0200 @@ -67,7 +67,8 @@ > rq->buffer = buf; > rq->buffer[0] = WIN_FLUSH_CACHE; > > - if (ide_id_has_flush_cache_ext(drive->id)) > + if (ide_id_has_flush_cache_ext(drive->id) && > + (drive->capacity64 >= (1UL << 28))) > rq->buffer[0] = WIN_FLUSH_CACHE_EXT; > } - -- Actually, what I'd like is a little toy spaceship!! -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.4 (GNU/Linux) iD8DBQFBCMKu1U5ZaPMbKQcRApIoAJ4tqGgBsO5nekX8zGzYchr08puxaQCePWiv xMyfv0AGbauPXXsxw1zSVA4= =aftH -----END PGP SIGNATURE----- ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Repost] IDE error 2.6.7-rc3-mm2 and 2.6.8-rc1-mm1 2004-07-29 9:26 ` tabris @ 2004-07-29 9:29 ` Jens Axboe 0 siblings, 0 replies; 6+ messages in thread From: Jens Axboe @ 2004-07-29 9:29 UTC (permalink / raw) To: tabris; +Cc: linux-kernel, Andrew Morton On Thu, Jul 29 2004, tabris wrote: > -----BEGIN PGP SIGNED MESSAGE----- > Hash: SHA1 > > On Tuesday 27 July 2004 3:52 pm, Jens Axboe wrote: > > On Tue, Jul 27 2004, tabris wrote: > > > On Thursday 22 July 2004 11:39 am, Jens Axboe wrote: > > > > On Thu, Jul 22 2004, Tabris wrote: > > > > > -----BEGIN PGP SIGNED MESSAGE----- > > > > > Hash: SHA1 > > > > > > > Try this. > Works. I don't see the error in my syslog anymore. Thank you. > Hopefully this fix will make it into -mm and/or mainline soon. It's already in the released 2.6.8-rc2-mm1 from yesterday. Thanks for testing and verifying it works, I'm sure Andrew appreciates that as well :-) -- Jens Axboe ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2004-07-29 9:30 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <200407220659.22948.tabris@tabriel.tabris.net>
2004-07-22 15:39 ` [Repost] IDE error 2.6.7-rc3-mm2 and 2.6.8-rc1-mm1 Jens Axboe
2004-07-23 10:14 ` tabris
2004-07-27 18:07 ` tabris
2004-07-27 19:52 ` Jens Axboe
2004-07-29 9:26 ` tabris
2004-07-29 9:29 ` Jens Axboe
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox