Re: [PATCH][2.6] Allow x86_64 to reenable interrupts on contention

William Lee Irwin III
2004-07-28T00:14:40Z

On Tue, 27 Jul 2004, Andi Kleen wrote:
>>> This will likely increase code size. Do you have numbers by how
>>> much? And is it really worth it?

Zwane Mwaikambo <zwane@linuxpower.ca> wrote:
>> Yes there is a growth;
>> text data bss dec hex filename
>> 3655358 1340511 486128 5481997 53a60d vmlinux-after
>> 3648445 1340511 486128 5475084 538b0c vmlinux-before

On Tue, Jul 27, 2004 at 12:01:25PM -0700, Andrew Morton wrote:
> The growth is all in the out-of-line section, so there should be no
> significant additional icache pressure.

There are also flash and similar absolute space footprints to consider.
Experiments seem to suggest that consolidating the lock sections and
other spinlock code can reduce kernel image size by as much as 220KB on
ia32 with no performance impact (rigorous benchmarks still in progress).

That said, I agree with zwane's interrupt enablement change.

-- wli