From: Andrew Morton <akpm@osdl.org>
To: Alan Cox <alan@redhat.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: PATCH: fix some 32bit isms
Date: Wed, 28 Jul 2004 09:23:34 -0700 [thread overview]
Message-ID: <20040728092334.74e0cfcd.akpm@osdl.org> (raw)
In-Reply-To: <20040728135941.GA17409@devserv.devel.redhat.com>
Alan Cox <alan@redhat.com> wrote:
>
> printk(MYIOC_s_ERR_FMT
> "Invalid IOC facts reply, msgLength=%d offsetof=%d!\n",
> - ioc->name, facts->MsgLength, (offsetof(IOCFactsReply_t,
> + ioc->name, facts->MsgLength, (int)(offsetof(IOCFactsReply_t,
printk expects %zd for a size_t
> RequestFrameSize)/sizeof(u32)));
> ...
> printk(KERN_WARNING "INFTL: allocation of PUtable "
> - "failed (%d bytes)\n",
> + "failed (%ld bytes)\n",
> inftl->nb_blocks * sizeof(u16));
Some architectures will emit a warning here, and will perhaps print the
wrong thing. We need to print size_t's with %zd. I'll fix that up.
next prev parent reply other threads:[~2004-07-28 16:30 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-07-28 13:59 PATCH: fix some 32bit isms Alan Cox
2004-07-28 15:42 ` H. Peter Anvin
2004-07-28 15:51 ` David S. Miller
2004-07-28 16:23 ` Andrew Morton [this message]
2004-07-28 16:27 ` Alan Cox
2004-08-06 22:53 ` H. Peter Anvin
2004-08-06 23:03 ` viro
2004-08-06 23:07 ` viro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040728092334.74e0cfcd.akpm@osdl.org \
--to=akpm@osdl.org \
--cc=alan@redhat.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox