From: Tom Rini <trini@kernel.crashing.org>
To: Olaf Hering <olh@suse.de>, Andrew Morton <akpm@osdl.org>,
linux-kernel@vger.kernel.org, linuxppc-dev@lists.linuxppc.org
Subject: Re: [PATCH] fix zlib debug in ppc boot header
Date: Wed, 28 Jul 2004 08:56:43 -0700 [thread overview]
Message-ID: <20040728155643.GO10891@smtp.west.cox.net> (raw)
In-Reply-To: <20040728174213.GA7226@mars.ravnborg.org>
On Wed, Jul 28, 2004 at 07:42:13PM +0200, Sam Ravnborg wrote:
> On Wed, Jul 28, 2004 at 08:29:40AM -0700, Tom Rini wrote:
> > On Wed, Jul 28, 2004 at 01:22:22PM +0200, Olaf Hering wrote:
> >
> > > The ppc bootloader code will not compile with zlib debug enabled.
> > > printf was not defined. Tested with vmlinux.coff
> > > This patch was sent out earlier. Appearently it is not possible
> > > to use the generic zlib copy in linux/lib
> > >
> > > Signed-off-by: Olaf Hering <olh@suse.de>
> >
> > Again, I do not want to see this. First, have you run into an occasion
> > where this was needed and helpful? Second, I would much rather see
> > someone just rip out zlib.c and replace it with lib/zlib_deflate than to
> > try and modify the code again.
>
> It should be possible just to include the zlib_deflate.o file from lib/.
> At least oprofile plays suchs ugly tricks.
Can you think of a cleaner way to do this?
--
Tom Rini
http://gate.crashing.org/~trini/
next prev parent reply other threads:[~2004-07-28 16:07 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-07-28 11:22 [PATCH] fix zlib debug in ppc boot header Olaf Hering
2004-07-28 11:34 ` Arjan van de Ven
2004-07-28 15:01 ` Tom Rini
2004-07-28 15:36 ` Olaf Hering
2004-07-28 23:06 ` Tom Rini
2004-07-29 6:48 ` Olaf Hering
2004-07-28 15:18 ` Geert Uytterhoeven
2004-07-28 15:29 ` Tom Rini
2004-07-28 17:42 ` Sam Ravnborg
2004-07-28 15:56 ` Tom Rini [this message]
2004-07-28 18:18 ` Sam Ravnborg
2004-07-28 16:39 ` Tom Rini
2004-07-28 16:47 ` Jörn Engel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040728155643.GO10891@smtp.west.cox.net \
--to=trini@kernel.crashing.org \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.linuxppc.org \
--cc=olh@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox