From: Andrew Morton <akpm@osdl.org>
To: Greg Howard <ghoward@sgi.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Altix system controller communication driver
Date: Wed, 28 Jul 2004 16:00:33 -0700 [thread overview]
Message-ID: <20040728160033.63205d60.akpm@osdl.org> (raw)
In-Reply-To: <Pine.SGI.4.58.0407281641210.1656@gallifrey.americas.sgi.com>
Greg Howard <ghoward@sgi.com> wrote:
>
> > > +static unsigned int
> > > +scdrv_poll(struct file *file, struct poll_table_struct *wait)
> > > +{
> > > + unsigned int mask = 0;
> > > + int status = 0;
> > > + struct subch_data_s *sd = (struct subch_data_s *) file->private_data;
> > > + unsigned long flags;
> > > +
> > > + scdrv_lock_all(sd, &flags);
> > > + poll_wait(file, &sd->sd_rq, wait);
> > > + poll_wait(file, &sd->sd_wq, wait);
> >
> > This function will sleep with spinlocks held, won't it?
>
> My understanding is that poll_wait just sets up a poll_table
> structure; it doesn't sleep itself.
It calls into __pollwait(), which can perform sleeping memory allocations.
next prev parent reply other threads:[~2004-07-28 22:59 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-07-27 20:07 [PATCH] Altix system controller communication driver Greg Howard
2004-07-28 15:11 ` Jes Sorensen
2004-07-28 15:57 ` Andrew Morton
2004-07-28 18:21 ` Sam Ravnborg
2004-07-29 19:46 ` Greg Howard
2004-07-28 22:11 ` Greg Howard
2004-07-28 23:00 ` Andrew Morton [this message]
2004-07-29 19:50 ` Greg Howard
2004-07-30 21:44 ` Greg Howard
2004-07-31 9:55 ` Christoph Hellwig
2004-08-01 0:55 ` Andrew Morton
2004-08-02 11:46 ` Greg Howard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040728160033.63205d60.akpm@osdl.org \
--to=akpm@osdl.org \
--cc=ghoward@sgi.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox