Re: [PATCH] Fix NR_KEYS off-by-one error

OGAWA Hirofumi
2004-07-16T17:20:46Z

Vojtech Pavlik <vojtech@suse.cz> writes:

> On Sat, Jul 17, 2004 at 01:35:59AM +0900, OGAWA Hirofumi wrote:
> > KDGKBENT ioctl can use 256 entries (0-255), but it was defined as
> > key_map[NR_KEYS] (NR_KEYS == 255). The code seems also thinking it's 256.
> >
> > key_map[0] = U(K_ALLOCATED);
> > for (j = 1; j < NR_KEYS; j++)
> > key_map[j] = U(K_HOLE);
>
> The patch below might cause problems, though, because some apps may (in
> old versions are) using a char variable to index up to NR_KEYS, which
> leads to an endless loop.

Maybe. But isn't it just bug of apps?
--
OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>