From: Ingo Molnar <mingo@elte.hu>
To: Scott Wood <scott@timesys.com>
Cc: linux-kernel@vger.kernel.org,
"La Monte H.P. Yarroll" <piggy@timesys.com>,
Manas Saksena <manas.saksena@timesys.com>
Subject: Re: [patch] IRQ threads
Date: Thu, 29 Jul 2004 21:33:41 +0200 [thread overview]
Message-ID: <20040729193341.GA27057@elte.hu> (raw)
In-Reply-To: <20040728231241.GE6685@yoda.timesys>
* Scott Wood <scott@timesys.com> wrote:
> > Also, why the enable_irq() change?
>
> If you mean the do_startup_irq() change, [...]
i mean the change below - why do irqthreads necessiate it?
Ingo
@@ -395,7 +402,14 @@ void enable_irq(unsigned int irq)
desc->status = status | IRQ_REPLAY;
hw_resend_irq(desc->handler,irq);
}
- desc->handler->enable(irq);
+
+ /* Don't unmask the IRQ if it's in progress, or else you
+ could re-enter the IRQ handler. As it is now enabled,
+ the IRQ will be unmasked when the handler is finished. */
+
+ if (!(desc->status & (IRQ_INPROGRESS | IRQ_THREADRUNNING |
+ IRQ_THREADPENDING)))
+ desc->handler->enable(irq);
/* fall-through */
}
default:
next prev parent reply other threads:[~2004-07-29 19:32 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-07-27 22:50 [patch] IRQ threads Scott Wood
2004-07-28 6:27 ` Ingo Molnar
2004-07-28 15:38 ` Karim Yaghmour
2004-07-28 16:01 ` Karim Yaghmour
2004-07-28 21:23 ` Bill Huey
2004-07-28 21:35 ` Scott Wood
2004-07-29 21:08 ` Bill Huey
2004-07-29 22:44 ` Ingo Molnar
2004-07-28 23:24 ` Scott Wood
2004-07-28 8:10 ` Ingo Molnar
2004-07-28 23:12 ` Scott Wood
2004-07-29 19:33 ` Ingo Molnar [this message]
2004-07-29 20:21 ` Scott Wood
2004-07-29 21:12 ` Alan Cox
2004-07-28 15:45 ` Karim Yaghmour
2004-07-28 18:28 ` Lee Revell
2004-07-28 19:12 ` Karim Yaghmour
2004-07-28 19:33 ` Lee Revell
2004-07-28 19:57 ` Karim Yaghmour
2004-07-28 20:35 ` Lee Revell
2004-07-28 21:15 ` Karim Yaghmour
2004-07-28 21:43 ` Lee Revell
2004-07-28 21:38 ` Karim Yaghmour
2004-07-28 20:21 ` Bill Huey
2004-07-28 20:42 ` Lee Revell
2004-07-28 20:46 ` Bill Huey
2004-07-28 21:48 ` Karim Yaghmour
2004-07-28 22:30 ` Bill Huey
2004-07-28 22:03 ` Philippe Gerum
-- strict thread matches above, loose matches on Subject: below --
2004-07-29 20:33 Albert Cahalan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040729193341.GA27057@elte.hu \
--to=mingo@elte.hu \
--cc=linux-kernel@vger.kernel.org \
--cc=manas.saksena@timesys.com \
--cc=piggy@timesys.com \
--cc=scott@timesys.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox