From: viro@parcelfarce.linux.theplanet.co.uk
To: Andrew Morton <akpm@osdl.org>
Cc: Jan Blunck <j.blunck@tu-harburg.de>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ext2_readdir() filp->f_pos fix
Date: Fri, 30 Jul 2004 01:00:14 +0100 [thread overview]
Message-ID: <20040730000014.GL12308@parcelfarce.linux.theplanet.co.uk> (raw)
In-Reply-To: <20040729154625.0a6f48a3.akpm@osdl.org>
On Thu, Jul 29, 2004 at 03:46:25PM -0700, Andrew Morton wrote:
> If the filldir() call returns non-zero your patch will leave f_pos pointing at
> the problematic directory entry. I'm not sure whether this is desirable.
>
> hmm, ext2_readir() isn't propagating EFAULT back up to the caller.
filldir callback does that. Please, read through fs/readdir.c and take
a look at the way error value is generated.
Return value of filldir has only one meaning - should we stop or should
we go on. It's boolean, not an error value.
Errors are stored in data we are passing to filldir and picked by caller
of vfs_readdir() once it's done.
next prev parent reply other threads:[~2004-07-30 0:03 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-07-29 19:18 [PATCH] ext2_readdir() filp->f_pos fix Jan Blunck
2004-07-29 22:46 ` Andrew Morton
2004-07-30 0:00 ` viro [this message]
2004-07-30 10:49 ` Jan Blunck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040730000014.GL12308@parcelfarce.linux.theplanet.co.uk \
--to=viro@parcelfarce.linux.theplanet.co.uk \
--cc=akpm@osdl.org \
--cc=j.blunck@tu-harburg.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox