public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Thomas Koeller <thomas.koeller@baslerweb.com>
To: linux-kernel@vger.kernel.org
Subject: [PATCH] Device class reference counting
Date: Fri, 30 Jul 2004 18:03:00 +0200	[thread overview]
Message-ID: <200407301803.00269.thomas.koeller@baslerweb.com> (raw)

Hi,

I found a little issue with reference counting for
device classes in 2.6.8-rc2. Patch attached. Please
cc me on any responses, as I am not subsribed to
this list.

tk



--- linux-mips/drivers/base/class.c	2004-07-14 16:21:33.000000000 +0200
+++ linux-mips-work/drivers/base/class.c	2004-07-30 17:51:09.477331128 +0200
@@ -353,8 +353,8 @@
 	struct class_interface * class_intf;
 	int error;
 
-	class_dev = class_device_get(class_dev);
-	if (!class_dev || !strlen(class_dev->class_id))
+	if (!strlen(class_dev->class_id)
+		|| !(class_dev = class_device_get(class_dev)))
 		return -EINVAL;
 
 	parent = class_get(class_dev->class);

-- 
--------------------------------------------------

Thomas Koeller, Software Development
Basler Vision Technologies

thomas dot koeller at baslerweb dot com
http://www.baslerweb.com

==============================

             reply	other threads:[~2004-07-30 16:01 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-07-30 16:03 Thomas Koeller [this message]
2004-08-05 22:46 ` [PATCH] Device class reference counting Greg KH
2004-08-06  9:37   ` Thomas Koeller
2004-08-06  9:43     ` Thomas Koeller
2004-08-06 19:47       ` Greg KH
2004-08-10 12:09         ` Thomas Koeller
2004-08-10 23:28           ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200407301803.00269.thomas.koeller@baslerweb.com \
    --to=thomas.koeller@baslerweb.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox