From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S267814AbUG3TtI (ORCPT ); Fri, 30 Jul 2004 15:49:08 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S267815AbUG3TtH (ORCPT ); Fri, 30 Jul 2004 15:49:07 -0400 Received: from twilight.ucw.cz ([81.30.235.3]:9600 "EHLO midnight.ucw.cz") by vger.kernel.org with ESMTP id S267814AbUG3Trd (ORCPT ); Fri, 30 Jul 2004 15:47:33 -0400 Date: Fri, 30 Jul 2004 21:48:54 +0200 From: Vojtech Pavlik To: Jon Smirl Cc: Jesse Barnes , lkml Subject: Re: Exposing ROM's though sysfs Message-ID: <20040730194854.GA436@ucw.cz> References: <20040730193546.GA328@ucw.cz> <20040730194150.7072.qmail@web14927.mail.yahoo.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20040730194150.7072.qmail@web14927.mail.yahoo.com> User-Agent: Mutt/1.4.1i Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jul 30, 2004 at 12:41:50PM -0700, Jon Smirl wrote: > I looked at PCI quirks, they all seem to be fixing chipset issues. Do > we want to start including adapter specific quirks along with the more > general chipset one? It's mostly chipsets, but not just chipsets - take a look at the S3 entries. > > --- Vojtech Pavlik wrote: > > > On Fri, Jul 30, 2004 at 12:25:10PM -0700, Jon Smirl wrote: > > > --- Jesse Barnes wrote: > > > > How about this patch? > > > > > > Here's the ROM access code I've been using but it's not in the form > > > that we need. > > > > > > We do need a standard scheme for the radeon situation of having a > > bug > > > in the ROM access logic. Is it ok to put the fix for this in the > > radeon > > > driver? So if you read the ROM before the driver is loaded it won't > > be > > > there (proabably FFFF's). After the driver loads the fix will run > > as > > > part of the driver init and the ROM access functions will work > > right. > > > > IMO the fix should go to the PCI quirk logic. That's a place to work > > around PCI config bugs. > > > > -- > > Vojtech Pavlik > > SuSE Labs, SuSE CR > > > > > ===== > Jon Smirl > jonsmirl@yahoo.com > > > > > __________________________________ > Do you Yahoo!? > New and Improved Yahoo! Mail - 100MB free storage! > http://promotions.yahoo.com/new_mail > -- Vojtech Pavlik SuSE Labs, SuSE CR