public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Marcelo Tosatti <marcelo.tosatti@cyclades.com>
To: Meelis Roos <mroos@linux.ee>
Cc: Linux Kernel list <linux-kernel@vger.kernel.org>
Subject: Re: [2.4 PATCH] problems with modular and nonmodular ide mix
Date: Sat, 31 Jul 2004 12:02:14 -0300	[thread overview]
Message-ID: <20040731150214.GG6497@logos.cnet> (raw)
In-Reply-To: <Pine.GSO.4.44.0407191332150.14892-100000@math.ut.ee>

On Mon, Jul 19, 2004 at 02:01:16PM +0300, Meelis Roos wrote:
> I was trying to figure out an unresolved modules symbol on PPC
> (2.4.27-BK): init_cmd640_vlb(). This is used in ide.c and defined in
> pci/cmd640.c. It appears that nothing from drivers/ide/pci is compiled
> at all - make traverses the directory but nothing gets compiled.
> Relevant part of .config is below.
> 
> So at least sl82c105 and cmd640 should get compiled but don't.
> 
> I suspected that since IDE is modular, only drivers configured as
> modules are compiled but not static ones. I set sl82c105 to M and it was
> compiled.
> 
> So the problem is that cmd640 can only be compiled in statically but not
> into modular IDE. What about the patch below to fix this? It builds
> and loads fine here, but it only fixes an obscure configuration.

Hi Meelis,

The thing is cmd640 can't be compiled as a module - just dont
use IDE modular if you need cmd640. 

> ===== drivers/ide/Config.in 1.41 vs edited =====
> --- 1.41/drivers/ide/Config.in	2004-05-22 23:30:37 +03:00
> +++ edited/drivers/ide/Config.in	2004-07-19 13:58:33 +03:00
> @@ -27,8 +27,10 @@
> 
>     comment 'IDE chipset support/bugfixes'
>     if [ "$CONFIG_BLK_DEV_IDE" != "n" ]; then
> -      dep_bool '  CMD640 chipset bugfix/support' CONFIG_BLK_DEV_CMD640 $CONFIG_X86
> -      dep_bool '    CMD640 enhanced support' CONFIG_BLK_DEV_CMD640_ENHANCED $CONFIG_BLK_DEV_CMD640
> +      dep_tristate '  CMD640 chipset bugfix/support' CONFIG_BLK_DEV_CMD640 $CONFIG_X86
> +      if [ "$CONFIG_BLK_DEV_CMD640" != "n" ]; then
> +         bool '    CMD640 enhanced support' CONFIG_BLK_DEV_CMD640_ENHANCED
> +      fi
>        dep_bool '  ISA-PNP EIDE support' CONFIG_BLK_DEV_ISAPNP $CONFIG_ISAPNP
>        if [ "$CONFIG_PCI" = "y" ]; then
>  	 bool '  PCI IDE chipset support' CONFIG_BLK_DEV_IDEPCI

  reply	other threads:[~2004-07-31 15:04 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-07-19 11:01 [2.4 PATCH] problems with modular and nonmodular ide mix Meelis Roos
2004-07-31 15:02 ` Marcelo Tosatti [this message]
2004-08-01 11:09   ` Meelis Roos
2004-08-02  0:12     ` Marcelo Tosatti
2004-08-05  5:11       ` Meelis Roos

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20040731150214.GG6497@logos.cnet \
    --to=marcelo.tosatti@cyclades.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mroos@linux.ee \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox