Re: 2.6.8-rc2-mm1

Ingo Molnar
2004-08-01T11:18:12Z

On Sat, 31 Jul 2004, Andrew Morton wrote:

> Sorry. Try this one instead.
>
> --- 25/fs/jbd/checkpoint.c~journal_clean_checkpoint_list-latency-fix-fix 2004-07-31 11:43:39.320530424 -0700
> +++ 25-akpm/fs/jbd/checkpoint.c 2004-07-31 13:20:22.562303576 -0700
> @@ -497,8 +497,8 @@ int __journal_clean_checkpoint_list(jour
> * We don't test cond_resched() here because another CPU could
> * be waiting on j_list_lock() while holding a different lock.
> */
> - if ((ret & 127) == 127) {
> - spin_unlock(&journal->j_list_lock);
> + transaction = journal->j_checkpoint_transactions
> + if (transaction && (ret & 127) == 127) {

this should cause a crash later on - 'transaction' is also the loop
variable here.

Ingo