public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Jens Axboe <axboe@suse.de>
To: David Ford <david+challenge-response@blue-labs.org>
Cc: linux-kernel mailing list <linux-kernel@vger.kernel.org>,
	wiggly@wiggly.org, dnarnold@yahoo.com, matt@mattcaron.net,
	seymour@astro.utoronto.ca
Subject: Re: cdrom: dropping to single frame dma
Date: Mon, 2 Aug 2004 15:24:57 +0200	[thread overview]
Message-ID: <20040802132457.GT10496@suse.de> (raw)
In-Reply-To: <41040A4B.6080703@blue-labs.org>

On Sun, Jul 25 2004, David Ford wrote:
> I've been trying to rip my CDs onto my HD, and last night after about 7 
> CDs I realized I was getting junk and it was taking forever to rip a 
> CD.  I'm using 2.6.8-rc2 and I have two different CD-ROMs in my 
> machine.  Both are burners.
> 
> I got a single "cdrom: dropping to single frame dma" message which 
> according to my research is part of the culprit.
> 
> See the thread on LKML back on 5/15/2004 titled "dma ripping", and again 
> on 6/15 titled "cdrom ripping / dropping to dingle frame dma" -- yes 
> that's a "d".
> 
> I'm guessing that Jens' patch for this didn't make it into the kernel.

Try this.

--- linux-2.6.8-rc2-mm1/drivers/cdrom/cdrom.c~	2004-08-02 14:56:48.259992912 +0200
+++ linux-2.6.8-rc2-mm1/drivers/cdrom/cdrom.c	2004-08-02 15:20:58.326549288 +0200
@@ -2004,6 +2004,8 @@
 	struct packet_command cgc;
 	int nr, ret;
 
+	cdi->last_sense = 0;
+
 	memset(&cgc, 0, sizeof(cgc));
 
 	/*
@@ -2055,6 +2057,8 @@
 	if (!q)
 		return -ENXIO;
 
+	cdi->last_sense = 0;
+
 	while (nframes) {
 		nr = nframes;
 		if (cdi->cdda_method == CDDA_BPC_SINGLE)
@@ -2102,6 +2106,7 @@
 
 		nframes -= nr;
 		lba += nr;
+		ubuf += len;
 	}
 
 	return ret;

-- 
Jens Axboe


  reply	other threads:[~2004-08-02 13:25 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-07-25 19:30 cdrom: dropping to single frame dma David Ford
2004-08-02 13:24 ` Jens Axboe [this message]
2004-08-03  9:59   ` Rogério Brito
2004-08-03 10:02     ` Jens Axboe
2004-08-04  0:36   ` David N. Arnold
2004-08-04  5:31     ` Jens Axboe
2004-08-06  1:43       ` David N. Arnold

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20040802132457.GT10496@suse.de \
    --to=axboe@suse.de \
    --cc=david+challenge-response@blue-labs.org \
    --cc=dnarnold@yahoo.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=matt@mattcaron.net \
    --cc=seymour@astro.utoronto.ca \
    --cc=wiggly@wiggly.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox