public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* boolean typo in DVB
@ 2004-08-03  1:00 Dave Jones
  2004-08-03 18:28 ` Johannes Stezenbach
  0 siblings, 1 reply; 2+ messages in thread
From: Dave Jones @ 2004-08-03  1:00 UTC (permalink / raw)
  To: ralph, marcus; +Cc: Linux Kernel

This looks like what was intended here..

		Dave


Signed-off-by: Dave Jones <davej@redhat.com>

--- 1/drivers/media/dvb/dvb-core/dvb_demux.c~	2004-08-03 01:57:45.605369592 +0100
+++ 2/drivers/media/dvb/dvb-core/dvb_demux.c	2004-08-03 01:57:58.979336440 +0100
@@ -179,7 +179,7 @@
 		neq |= f->maskandnotmode[i] & xor;
 	}
 
-	if (f->doneq & !neq)
+	if (f->doneq && !neq)
 		return 0;
 
 	return feed->cb.sec (feed->feed.sec.secbuf, feed->feed.sec.seclen, 

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: boolean typo in DVB
  2004-08-03  1:00 boolean typo in DVB Dave Jones
@ 2004-08-03 18:28 ` Johannes Stezenbach
  0 siblings, 0 replies; 2+ messages in thread
From: Johannes Stezenbach @ 2004-08-03 18:28 UTC (permalink / raw)
  To: Dave Jones; +Cc: linux-kernel

(The email addresses in the source files are out of date,
bug reports should go to linux-dvb-maintainer [at] linuxtv.org.)

Dave Jones wrote:
> This looks like what was intended here..
...
> Signed-off-by: Dave Jones <davej@redhat.com>
> 
> --- 1/drivers/media/dvb/dvb-core/dvb_demux.c~	2004-08-03 01:57:45.605369592 +0100
> +++ 2/drivers/media/dvb/dvb-core/dvb_demux.c	2004-08-03 01:57:58.979336440 +0100
> @@ -179,7 +179,7 @@
>  		neq |= f->maskandnotmode[i] & xor;
>  	}
>  
> -	if (f->doneq & !neq)
> +	if (f->doneq && !neq)
>  		return 0;
>  
>  	return feed->cb.sec (feed->feed.sec.secbuf, feed->feed.sec.seclen, 

Yes, you've spotted a bug. I'll correct this in linuxtv CVS.

Thanks a lot,
Johannes

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2004-08-03 18:28 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2004-08-03  1:00 boolean typo in DVB Dave Jones
2004-08-03 18:28 ` Johannes Stezenbach

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox