public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Johannes Stezenbach <js@convergence.de>
To: Dave Jones <davej@redhat.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: boolean typo in DVB
Date: Tue, 3 Aug 2004 20:28:24 +0200	[thread overview]
Message-ID: <20040803182824.GB2628@convergence.de> (raw)
In-Reply-To: <20040803010055.GB12571@redhat.com>

(The email addresses in the source files are out of date,
bug reports should go to linux-dvb-maintainer [at] linuxtv.org.)

Dave Jones wrote:
> This looks like what was intended here..
...
> Signed-off-by: Dave Jones <davej@redhat.com>
> 
> --- 1/drivers/media/dvb/dvb-core/dvb_demux.c~	2004-08-03 01:57:45.605369592 +0100
> +++ 2/drivers/media/dvb/dvb-core/dvb_demux.c	2004-08-03 01:57:58.979336440 +0100
> @@ -179,7 +179,7 @@
>  		neq |= f->maskandnotmode[i] & xor;
>  	}
>  
> -	if (f->doneq & !neq)
> +	if (f->doneq && !neq)
>  		return 0;
>  
>  	return feed->cb.sec (feed->feed.sec.secbuf, feed->feed.sec.seclen, 

Yes, you've spotted a bug. I'll correct this in linuxtv CVS.

Thanks a lot,
Johannes

      reply	other threads:[~2004-08-03 18:28 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-08-03  1:00 boolean typo in DVB Dave Jones
2004-08-03 18:28 ` Johannes Stezenbach [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20040803182824.GB2628@convergence.de \
    --to=js@convergence.de \
    --cc=davej@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox