From: Jens Axboe <axboe@suse.de>
To: Brian King <brking@us.ibm.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] blk_queue_free_tags
Date: Wed, 4 Aug 2004 07:39:10 +0200 [thread overview]
Message-ID: <20040804053909.GB10340@suse.de> (raw)
In-Reply-To: <410FCFAF.3090207@us.ibm.com>
On Tue, Aug 03 2004, Brian King wrote:
>
> --
> Brian King
> eServer Storage I/O
> IBM Linux Technology Center
>
> Currently blk_queue_free_tags cannot be called with ops outstanding. The
> scsi_tcq API defined to LLD scsi drivers allows for scsi_deactivate_tcq
> to be called (which calls blk_queue_free_tags) with ops outstanding. Change
> blk_queue_free_tags to no longer free the tags, but rather just disable
> tagged queuing and also modify blk_queue_init_tags to handle re-enabling
> tagged queuing after it has been disabled.
Not sure I completely agree with changing our exported interface just
because that's what SCSI wants, but I guess there's no harm. As long as
the tags are freed on queue exit, we can leave them around. I'll just
make it __blk_queue_free_tags(), else applied directly.
--
Jens Axboe
prev parent reply other threads:[~2004-08-04 5:39 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-08-03 17:47 [PATCH] blk_queue_free_tags Brian King
2004-08-04 5:39 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040804053909.GB10340@suse.de \
--to=axboe@suse.de \
--cc=brking@us.ibm.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox