public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* [via-rhine] Really call rhine_power_init()
@ 2004-08-04  9:37 Roger Luethi
  0 siblings, 0 replies; only message in thread
From: Roger Luethi @ 2004-08-04  9:37 UTC (permalink / raw)
  To: Linus Torvalds, Andrew Morton; +Cc: linux-kernel, Jeff Garzik

This is a fix for the heisenbug with via-rhine refusing to work
sometimes. Patch "[9/9] Restructure reset code" contained a change made
necessary by patch [8/9]. Mainline merged [8/9] for 2.6.8 and is still
missing the fix, while -mm got it with [9/9].

Jesper Juhl provided crucial test data when no one else was able to
reproduce the symptoms.

Roger

Signed-off-by: Roger Luethi <rl@hellgate.ch>

--- tmp/drivers/net/via-rhine.c.00_broken	2004-07-29 13:58:17.000000000 +0200
+++ tmp/drivers/net/via-rhine.c	2004-07-30 15:12:36.656007543 +0200
@@ -748,6 +748,8 @@ static int __devinit rhine_init_one(stru
 	}
 #endif /* USE_MMIO */
 	dev->base_addr = ioaddr;
+	rp = netdev_priv(dev);
+	rp->quirks = quirks;
 
 	rhine_power_init(dev);
 
@@ -792,10 +794,8 @@ static int __devinit rhine_init_one(stru
 
 	dev->irq = pdev->irq;
 
-	rp = netdev_priv(dev);
 	spin_lock_init(&rp->lock);
 	rp->pdev = pdev;
-	rp->quirks = quirks;
 	rp->mii_if.dev = dev;
 	rp->mii_if.mdio_read = mdio_read;
 	rp->mii_if.mdio_write = mdio_write;

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2004-08-04  9:38 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2004-08-04  9:37 [via-rhine] Really call rhine_power_init() Roger Luethi

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox