Re: [sparc32] [12/13] gcc-3.3 macro parenthesization fix for memcpy.S

William Lee Irwin III
2004-08-05T07:39:49Z

On Wed, Aug 04, 2004 at 10:01:41PM -0700, William Lee Irwin III wrote:
>> From: Art Haas <ahaas@airmail.net>
>> The 1.3->1.4 changes to the arch/sparc/lib/copy_user.S file added
>> parenthesis to a number of macros within that file. The BK changlog
>> associated with this change indicate the change was to make the
>> file work with gcc-3.3.
>> When looking at the changes made, I see that similar macros exist in
>> memcpy.S as well, so would a patch adding parens to that file be
>> worthwhile? Also, just what was the problem with gcc-3.3 that was
>> resolved by adding the parenthesis? Macro mis-expansion I'm guessing.

On Thu, Aug 05, 2004 at 03:28:38AM -0400, Jakub Jelinek wrote:
> The problem was an (already fixed) gas bug, which for a short time treated
> %reg - -0x02
> as if there was a -- operator in between.
> arch/arch/lib/memcpy.S never passes -0xNN offsets to any of these macros,
> so the parenthesis is unnecessary there IMHO.

I'd be inclined to take it anyway, as macros should generally
parenthesize their arguments, though it's good to know what specific
toolchain issue the copy_user.S change was meant to deal with.

Thanks.

-- wli