From: Andi Kleen <ak@suse.de>
To: Sam Ravnborg <sam@ravnborg.org>
Cc: tduffy@sun.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Fix x86_64 build of mmconfig.c
Date: Thu, 5 Aug 2004 23:12:14 +0200 [thread overview]
Message-ID: <20040805231214.090463d9.ak@suse.de> (raw)
In-Reply-To: <20040805205401.GB22342@mars.ravnborg.org>
On Thu, 5 Aug 2004 22:54:01 +0200
Sam Ravnborg <sam@ravnborg.org> wrote:
> On Thu, Aug 05, 2004 at 10:32:05PM +0200, Andi Kleen wrote:
> > On Thu, 05 Aug 2004 10:48:16 -0700
> > Tom Duffy <tduffy@sun.com> wrote:
> >
> > > Signed-by: Tom Duffy <tduffy@sun.com>
> > >
> > > gcc -Wp,-MD,arch/x86_64/pci/.mmconfig.o.d -nostdinc -iwithprefix include -D__KERNEL__ -Iinclude -Iinclude2 -I/build1/tduffy/openib-work/linux-2.6.8-rc3-openib/include -I/build1/tduffy/openib-work/linux-2.6.8-rc3-openib/arch/x86_64/pci -Iarch/x86_64/pci -Wall -Wstrict-prototypes -Wno-trigraphs -fno-strict-aliasing -fno-common -mno-red-zone -mcmodel=kernel -pipe -fno-reorder-blocks -Wno-sign-compare -fno-asynchronous-unwind-tables -O2 -fomit-frame-pointer -Wdeclaration-after-statement -I/build1/tduffy/openib-work/linux-2.6.8-rc3-openib/ -I arch/i386/pci -DKBUILD_BASENAME=mmconfig -DKBUILD_MODNAME=mmconfig -c -o arch/x86_64/pci/mmconfig.o /build1/tduffy/openib-work/linux-2.6.8-rc3-openib/arch/x86_64/pci/mmconfig.c
> > > /build1/tduffy/openib-work/linux-2.6.8-rc3-openib/arch/x86_64/pci/mmconfig.c:10:17: pci.h: No such file or directory
> > >
> > > --- arch/x86_64/pci/Makefile.orig 2004-08-05 09:54:24.932007000 -0700
> > > +++ arch/x86_64/pci/Makefile 2004-08-05 09:53:53.171006000 -0700
> > > @@ -3,7 +3,7 @@
> > > #
> > > # Reuse the i386 PCI subsystem
> > > #
> > > -CFLAGS += -I arch/i386/pci
> > > +CFLAGS += -Iarch/i386/pci
> >
> > It never failed this way for me in hundreds of builds. Why is it failing for you?
> > What gcc version do you use?
> >
> > Normally -Ifoo and -I foo should be really equivalent.
>
> Notice the originally poster uses the make O=dir syntax - visible from the include2
> directory being present on the commandline.
>
> This issue is kbuild related. When using 'make O=dir' syntax kbuild process
> options passed to gcc, and all -Isomething are processed.
[...]
Thanks for the explanation, Sam. I don't use O=, so this would explain it.
I added the change for now.
-Andi
prev parent reply other threads:[~2004-08-05 21:15 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-08-05 17:48 [PATCH] Fix x86_64 build of mmconfig.c Tom Duffy
2004-08-05 20:32 ` Andi Kleen
2004-08-05 20:49 ` Tom Duffy
2004-08-05 20:54 ` Sam Ravnborg
2004-08-05 21:12 ` Andi Kleen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040805231214.090463d9.ak@suse.de \
--to=ak@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=sam@ravnborg.org \
--cc=tduffy@sun.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox