From: Thomas Koeller <thomas.koeller@baslerweb.com>
To: Greg KH <greg@kroah.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Device class reference counting
Date: Fri, 6 Aug 2004 11:43:47 +0200 [thread overview]
Message-ID: <200408061143.47858.thomas.koeller@baslerweb.com> (raw)
In-Reply-To: <200408061137.47099.thomas.koeller@baslerweb.com>
Sorry,
seems the patch got messsed up somehow, so I am
resending it:
--- linux-mips/drivers/base/class.c 2004-07-14 16:21:33.000000000 +0200
+++ linux-mips-work/drivers/base/class.c 2004-08-06 11:06:10.983688216 +0200
@@ -349,14 +349,19 @@
int class_device_add(struct class_device *class_dev)
{
- struct class * parent;
+ struct class * parent = NULL;
struct class_interface * class_intf;
int error;
class_dev = class_device_get(class_dev);
- if (!class_dev || !strlen(class_dev->class_id))
+ if (!class_dev)
return -EINVAL;
+ if (!strlen(class_dev->class_id)) {
+ error = -EINVAL;
+ goto register_done;
+ }
+
parent = class_get(class_dev->class);
pr_debug("CLASS: registering class device: ID = '%s'\n",
--
--------------------------------------------------
Thomas Koeller, Software Development
Basler Vision Technologies
thomas dot koeller at baslerweb dot com
http://www.baslerweb.com
==============================
next prev parent reply other threads:[~2004-08-06 9:42 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-07-30 16:03 [PATCH] Device class reference counting Thomas Koeller
2004-08-05 22:46 ` Greg KH
2004-08-06 9:37 ` Thomas Koeller
2004-08-06 9:43 ` Thomas Koeller [this message]
2004-08-06 19:47 ` Greg KH
2004-08-10 12:09 ` Thomas Koeller
2004-08-10 23:28 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200408061143.47858.thomas.koeller@baslerweb.com \
--to=thomas.koeller@baslerweb.com \
--cc=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox