From: William Lee Irwin III <wli@holomorphy.com>
To: "Chen, Kenneth W" <kenneth.w.chen@intel.com>
Cc: "'Hirokazu Takahashi'" <taka@valinux.co.jp>,
linux-kernel@vger.kernel.org, linux-ia64@vger.kernel.org, "Seth,
Rohit" <rohit.seth@intel.com>
Subject: Re: Hugetlb demanding paging for -mm tree
Date: Fri, 6 Aug 2004 14:07:50 -0700 [thread overview]
Message-ID: <20040806210750.GT17188@holomorphy.com> (raw)
In-Reply-To: <200408062055.i76KtcY08296@unix-os.sc.intel.com>
On Fri, Aug 06, 2004 at 01:55:38PM -0700, Chen, Kenneth W wrote:
> diff -Nurp linux-2.6.7/mm/hugetlb.c linux-2.6.7.hugetlb/mm/hugetlb.c
> --- linux-2.6.7/mm/hugetlb.c 2004-08-06 11:44:59.000000000 -0700
> +++ linux-2.6.7.hugetlb/mm/hugetlb.c 2004-08-06 13:15:24.000000000 -0700
> @@ -276,9 +276,10 @@ retry:
> }
>
> spin_lock(&mm->page_table_lock);
> - if (pte_none(*pte))
> + if (pte_none(*pte)) {
> set_huge_pte(mm, vma, page, pte, vma->vm_flags & VM_WRITE);
> - else
> + update_mmu_cache(vma, addr, *pte);
> + } else
> put_page(page);
> out:
> spin_unlock(&mm->page_table_lock);
update_mmu_cache() does not appear to check the size of the translation
to be established in many architectures. e.g. on arch/ia64/ it does
flush_icache_range(addr, addr + PAGE_SIZE) unconditionally, and only
sets PG_arch_1 on a single struct page. Similar comments apply to
sparc64 and ppc64; I didn't check any others.
-- wli
next prev parent reply other threads:[~2004-08-06 21:08 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-08-05 13:29 Hugetlb demanding paging for -mm tree Chen, Kenneth W
2004-08-05 13:36 ` William Lee Irwin III
2004-08-05 13:39 ` Chen, Kenneth W
2004-08-05 16:35 ` Hirokazu Takahashi
2004-08-06 20:55 ` Chen, Kenneth W
2004-08-06 21:07 ` William Lee Irwin III [this message]
2004-08-07 8:13 ` William Lee Irwin III
2004-08-09 18:19 ` Chen, Kenneth W
2004-08-09 19:12 ` William Lee Irwin III
2004-08-07 8:36 ` William Lee Irwin III
2004-08-09 18:54 ` Chen, Kenneth W
2004-08-09 19:12 ` William Lee Irwin III
2004-08-05 13:42 ` Chen, Kenneth W
2004-08-05 14:04 ` Andi Kleen
2004-08-06 21:06 ` Chen, Kenneth W
2004-08-05 13:43 ` Andi Kleen
-- strict thread matches above, loose matches on Subject: below --
2004-08-09 18:43 Seth, Rohit
2004-08-09 18:59 ` William Lee Irwin III
2004-08-10 8:52 Seth, Rohit
2004-08-10 8:55 ` William Lee Irwin III
2004-08-11 0:28 Seth, Rohit
2004-08-11 0:45 ` William Lee Irwin III
2004-08-11 6:36 Seth, Rohit
2004-08-11 6:38 ` William Lee Irwin III
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040806210750.GT17188@holomorphy.com \
--to=wli@holomorphy.com \
--cc=kenneth.w.chen@intel.com \
--cc=linux-ia64@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rohit.seth@intel.com \
--cc=taka@valinux.co.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox