From: Vincent Hanquez <tab@snarc.org>
To: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: lkml <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH][RESENT] remove hardcoded offsets from ppc asm
Date: Sun, 8 Aug 2004 12:25:12 +0200 [thread overview]
Message-ID: <20040808102512.GA13798@snarc.org> (raw)
In-Reply-To: <1091921531.14102.2.camel@gaston>
On Sun, Aug 08, 2004 at 09:32:12AM +1000, Benjamin Herrenschmidt wrote:
> On Sun, 2004-08-08 at 01:18, Vincent Hanquez wrote:
> > Hi LKML,
> >
> > This patch removes hardcoded offsets from ppc asm.
> > It generate offsets for thread_info structure instead of hardcoding them.
> >
> > Please apply or comments,
> >
> > Signed-off-by: Vincent Hanquez <tab@snarc.org>
>
> I have nothing against the idea, but why the hell did you change the
> constant names, turning them partially to lowercase ? They are just
> fine beeing uppercase, this is more consistent, and that would
> reduce the size of your patch signficantly.
Hi Benjamin, it seems to be the 'convention'. I did the same comment
some time ago to Brian Gerst with his patch for i386.
http://marc.theaimsgroup.com/?l=linux-kernel&m=108454158825656&w=2
But if you prefer a smaller patch, without changing the constant
name, I can do that too.
Sorry about the first set of patch, I didn't see your reply. I just saw
it today on the archive.
--
Tab
next prev parent reply other threads:[~2004-08-08 10:25 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-08-07 15:18 [PATCH][RESENT] remove hardcoded offsets from ppc asm Vincent Hanquez
2004-08-07 23:32 ` Benjamin Herrenschmidt
2004-08-08 10:25 ` Vincent Hanquez [this message]
2004-08-08 10:25 ` Benjamin Herrenschmidt
2004-08-08 10:52 ` Vincent Hanquez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040808102512.GA13798@snarc.org \
--to=tab@snarc.org \
--cc=benh@kernel.crashing.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox